Simulariumio should error if Agent IDs are too large
#78
Solution
If agent IDs are larger than a 32-bit signed int, throw a data error instead of writing to the .simulariumio file. This check is optional, and users can save with the validate_ids argument set to False if they want to avoid the additional validation step in order to improve performance.
I also manually verified that all of our converters are generating agent IDs sensibly and not continuing to increment agent IDs unnecessarily in subsequent time steps.
Type of change
Bug fix (non-breaking change which fixes an issue)
Change summary:
Add check in writer to verify that all agent IDs are small enough to be represented as a 32 bit signed int
Problem
Simulariumio should error if Agent IDs are too large #78
Solution
If agent IDs are larger than a 32-bit signed int, throw a data error instead of writing to the .simulariumio file. This check is optional, and users can save with the
validate_ids
argument set toFalse
if they want to avoid the additional validation step in order to improve performance.I also manually verified that all of our converters are generating agent IDs sensibly and not continuing to increment agent IDs unnecessarily in subsequent time steps.
Type of change
Change summary: