Closed ascibisz closed 1 year ago
Base: 90.56% // Head: 91.74% // Increases project coverage by +1.17%
:tada:
Coverage data is based on head (
d255180
) compared to base (b303ede
). Patch coverage: 99.80% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Problem
The trajectory converter tests test huge chunks of data, which makes it difficult to identify what's going on when on e fails. Ticket #98
Solution
What I did to solve this problem
Change summary:
Note: my linear algebra knowledge is limited, so please look closer at
test_mcell_converter
because I tried to write tests to test the functionality ofMcellConverter._get_euler_angles()
and some other related functions and they pass, but I certainly could be doing something naive that isn't actually testing sufficiently.