simularium / simulariumio

Python package that converts simulation outputs to the format consumed by the Simularium viewer website
Apache License 2.0
5 stars 3 forks source link

Updates to smoldyn UI template #129

Closed blairlyons closed 1 year ago

blairlyons commented 2 years ago

Problem

In the process of implementing autoconversion for Smoldyn, we identified updates that need to be made to the template files:

Solution

I added a "match" field for smoldyn_data's file_contents with a regex pattern to validate that the path is for a txt file.

Let me know if there's a better way to do this!

Type of change

Change summary:

codecov-commenter commented 1 year ago

Codecov Report

Base: 90.51% // Head: 90.56% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (b95338a) compared to base (53f416a). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #129 +/- ## ========================================== + Coverage 90.51% 90.56% +0.05% ========================================== Files 97 97 Lines 3510 3531 +21 ========================================== + Hits 3177 3198 +21 Misses 333 333 ``` | [Impacted Files](https://codecov.io/gh/simularium/simulariumio/pull/129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [simulariumio/readers/simularium\_binary\_reader.py](https://codecov.io/gh/simularium/simulariumio/pull/129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2ltdWxhcml1bWlvL3JlYWRlcnMvc2ltdWxhcml1bV9iaW5hcnlfcmVhZGVyLnB5) | `90.52% <0.00%> (-0.10%)` | :arrow_down: | | [simulariumio/tests/test\_input\_file\_data.py](https://codecov.io/gh/simularium/simulariumio/pull/129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2ltdWxhcml1bWlvL3Rlc3RzL3Rlc3RfaW5wdXRfZmlsZV9kYXRhLnB5) | `100.00% <0.00%> (ø)` | | | [simulariumio/tests/readers/test\_binary\_reader.py](https://codecov.io/gh/simularium/simulariumio/pull/129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2ltdWxhcml1bWlvL3Rlc3RzL3JlYWRlcnMvdGVzdF9iaW5hcnlfcmVhZGVyLnB5) | `100.00% <0.00%> (ø)` | | | [simulariumio/data\_objects/input\_file\_data.py](https://codecov.io/gh/simularium/simulariumio/pull/129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2ltdWxhcml1bWlvL2RhdGFfb2JqZWN0cy9pbnB1dF9maWxlX2RhdGEucHk=) | `96.66% <0.00%> (+1.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

blairlyons commented 1 year ago

@ascibisz updates lgtm!