Write clearer unit tests that test the particular functionality of the converter, with smaller chunks of expected data.
Make sure both the default settings, and all the optional input data are covered in the tests.
Currently, the tests cover so much of the data, that if one thing changed, all the tests would fail, instead of just the tests that would tell you what particular thing had changed, so has a developer, it would be challenging to figure out if you had introduced a bug or if you just need to update the expected data in the test. It would also make the test files a lot easier to read.
What needs to happen?
Write clearer unit tests that test the particular functionality of the converter, with smaller chunks of expected data. Make sure both the default settings, and all the optional input data are covered in the tests.
The cellPACK converter tests are a good example of how we want to break up tests https://github.com/simularium/simulariumio/blob/main/simulariumio/tests/converters/test_cellpack_converter.py
Why should we do this?
Currently, the tests cover so much of the data, that if one thing changed, all the tests would fail, instead of just the tests that would tell you what particular thing had changed, so has a developer, it would be challenging to figure out if you had introduced a bug or if you just need to update the expected data in the test. It would also make the test files a lot easier to read.
When does this need to get done?