Open SaturnHafen opened 1 year ago
I think the problem is that we just create Node
s without any reference to geo_node
s: https://github.com/simulate-digital-rail/planpro-importer/blob/main/planpro_importer/reader.py#L29-L32
When comparing to the ORM-Importer, it seems like GeoNode
s are manually created there: https://github.com/simulate-digital-rail/orm-importer/blob/main/orm_importer/importer.py#L69-L74
I don't know enough about PlanPro to suggest a fix myself. Hope this helps :)
@SaturnHafen This problem is fixed in here: https://github.com/simulate-digital-rail/planpro-importer/pull/6 That PR is waiting for review, but please try to checkout that branch and test it again. If it works, please close this issue.
Trying to install the package on the new branch using poetry (Adjusting the corresponding line in pyproject.toml
and running poetry lock
and poetry install
) fails due to mismatching dependency-versions on the new branch*. Regardless if the fix works, we would need to update the dependencies here (using poetry lock
), otherwise the fix would not be installed when using poetry install
. I am going to leave the issue open until that has happened.
*If you are interested in the dependency-problems:
Because planpro-importer (1.9.0) @ git+https://github.com/simulate-digital-rail/planpro-importer@coordinates-name depends on yaramo (0.1.0) @ git+https://github.com/simulate-digital-rail/yaramo.git
and sumoexporter depends on yaramo (0.1.0) @ git+https://github.com/simulate-digital-rail/yaramo, planpro-importer is forbidden.
So, because sumoexporter depends on planpro_importer (1.9.0) @ git+https://github.com/simulate-digital-rail/planpro-importer@coordinates-name, version solving failed.
My guess is that the different projects (sumo-exporter
and planpro-importer
) depend on different commit-hashes of yaramo which creates this specific problem. We might need to watch out when merging the modified poetry.lock
-file here so this issue does not prevent others from trying the example.
Trying to install the package on the new branch using poetry (Adjusting the corresponding line in
pyproject.toml
and runningpoetry lock
andpoetry install
) fails due to mismatching dependency-versions on the new branch*. Regardless if the fix works, we would need to update the dependencies here (usingpoetry lock
), otherwise the fix would not be installed when usingpoetry install
. I am going to leave the issue open until that has happened.*If you are interested in the dependency-problems:
Because planpro-importer (1.9.0) @ git+https://github.com/simulate-digital-rail/planpro-importer@coordinates-name depends on yaramo (0.1.0) @ git+https://github.com/simulate-digital-rail/yaramo.git and sumoexporter depends on yaramo (0.1.0) @ git+https://github.com/simulate-digital-rail/yaramo, planpro-importer is forbidden. So, because sumoexporter depends on planpro_importer (1.9.0) @ git+https://github.com/simulate-digital-rail/planpro-importer@coordinates-name, version solving failed.
My guess is that the different projects (
sumo-exporter
andplanpro-importer
) depend on different commit-hashes of yaramo which creates this specific problem. We might need to watch out when merging the modifiedpoetry.lock
-file here so this issue does not prevent others from trying the example.
Different commit hashes aren't a problem for poetry as it understands the relation between different commits in git. This is due to the fact that one project depens on the URL ending with yaramo.git, the other on one ending in yaramo. This was fixed in https://github.com/simulate-digital-rail/planpro-importer/commit/d7922c4cbfa586321db177d8fce6355d0f983e96, but the branch in https://github.com/simulate-digital-rail/planpro-importer/pull/6 is out of date with the main branch, so it doesn't contain this fix and breaks.
When trying to run the example, the program crashes with an
AtributeError
.Stack trace: