simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.33k stars 680 forks source link

Warrior ability multipliers have not been updated for hotfixes. #1338

Closed navv1234 closed 8 years ago

navv1234 commented 8 years ago

Originally reported on Google Code with ID 1339

What steps will reproduce the problem?
Just checking the details of each ability, shows pre-hotfix damage multipliers. 

What is the expected output? What do you see instead?

Honestly, I'm not 100% sure what the abilities do now because they have been balanced
2-3 times in the last few weeks and blizzard hasn't been specific with each change.
However, these are my educated guesses based on:

http://us.battle.net/wow/en/blog/7207170/Patch_505_Hotfixes_-10_2_2012

Mortal Strike now does 175% weapon damage (down from 185%)
Overpower now does 105% weapon damage (down from 120%)
Slam now does 190% weapon damage (down from 215%)
Raging Blow now does 190% weapon damage (down from 215%)
Bloodthirst now does 90% weapon damage (down from 100%)
Wild Strike now does 230% weapon damage (up from 220%)
Execute now does 300% weapon damage (down from 325%)

What version of the product are you using? On what operating system?
505-2 build 16057

Please provide any additional information below.
Other classes had various changes as well in these hotfixes and probably are worth
looking into as well.

Reported by s.alexlowery on 2012-10-05 15:49:22

navv1234 commented 8 years ago
Not too sure about Execute, but here are the hotfixes released in chronological order:

October 1
- Revenge now deals 50% damage to a secondary target, and 25% damage to a third target.
- Deep Wounds now does 50% less damage for Protection warriors only.
- Wild Strikes that consume the last charge of Bloodsurge will now properly cause a
one second global cooldown, rather than a 1.5 second global cooldown.

September 25
- Wild Strike damage has been increased by 18%.
- Execute damage has been decreased by 7%.
- Mortal Strike damage has been increased by 5%.

September 20
- Mortal Strike now does 165% weapon damage (down from 185%).
- Overpower now does 105% weapon damage (down from 120%)
- Slam now does 190% weapon damage (down from 215%).
- Raging Blow now does 190% weapon damage (down from 215%),
- Bloodthirst now does 90% weapon damage (down from 100%).
- Wild Strike now does 195% weapon damage (down from 220%).

Reported by antonmb on 2012-10-15 00:33:46

navv1234 commented 8 years ago
And here are the data mined stuff from 5.1 PTR that according to Ghostcrawler on Twitter,
"Nearly all data-mined 5.1 class changes are old hotfixes that everyone already has.
We haven't made many new 5.1 class changes yet."

https://twitter.com/Ghostcrawler/status/256480514020626432

- Execute damage reduced by 7%. AP scaling reduced by 8%.
- Raging Blow now does 190% weapon damage, down from 215%.
- Raging Blow Off-Hand now does 190% weapon damage, down from 215%.

Arms
- Mortal Strike now does 175% weapon damage plus 2,693, down from 185% weapon damage
plus 2,703.
- Overpower (Arms) now does 105% weapon damage, down from 120%.
- Slam now does 190% weapon damage plus 1,894, down from 215% weapon damage plus 2,144.

Arms & Fury
- Colossus Smash Smashes a target for 175% weapon damage plus 388 and weakens their
defenses, allowing your attacks to entirely bypass 100% of their armor for 6 sec, and
causes the Physical Vulnerability effect on the target.

Fury
- Bloodthirst now does 90% weapon damage plus 1,121, down from 100% weapon damage plus
1,246.
- Raging Blow now does 190% weapon damage, down from 215%.
- Wild Strike now does 230% weapon damage plus 1,003, up from 220% weapon damage plus
823.

Reported by antonmb on 2012-10-15 00:35:55

navv1234 commented 8 years ago
The problem with listing all those hotfixes in a relative way ( X was 
nerfed by Y% ), is that for a non-warrior dev like me, I can't easily 
verify whether that hotfix already got applied to the tooltip ( in which 
case it already get's picked up by SimC, assuming we have the latest wow 
build in our database ), or whether it is a hidden hotfix, where you can 
explicitly verify that the damage you should do according to the tooltip 
is off by some significant margin.

So instead of just listing all hotfixes, which may cause a double-nerf 
in SimC, I'd need a list of verified differences between the actual 
damage done ingame and the ingame tooltip, and it being caused by such a 
hotfix.

Oh and there's always the option of warrior developers joining the 
SimulationCraft team. Messing around in the class modules ( and not the 
SimC Core code ) is very very easy, and there are always people in irc 
which can help with any questions. So if anyone is interested, for 
example in taking care of all those small hotfixes in the future, let us 
know.

Reported by philoptik on 2012-10-15 09:00:24

navv1234 commented 8 years ago
The hotfixes are currently not yet reflected in the tooltips according to Ghostcrawler.
The tooltip updates will come in 5.1 and are currently on the PTR.

Reported by antonmb on 2012-10-15 13:27:37

navv1234 commented 8 years ago
Just commited changes.

http://code.google.com/p/simulationcraft/source/detail?r=14427

Reported by antonmb on 2012-10-15 17:47:33