simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.4k stars 692 forks source link

[GUI] Support all scaling stats (dodge/parry) in the scaling options. #1709

Closed navv1234 closed 9 years ago

navv1234 commented 9 years ago

Originally reported on Google Code with ID 1710

What steps will reproduce the problem?
1. Set Overrides to "scale_over=dps". Set Scaling to "Analyze all Stats"
2. Run Simulation for Protection WarriorTank

What is the expected output? What do you see instead?
I would expect to see Damage Scale Factors for Parry/Dodge in the Result. More Parry
should lead to more "Revenge" Attacks. Dodge might have an negative Effect on DPS.

Instead no Scale Factors for Parry/Dodge are created.

What version of the product are you using? On what operating system?
SimulationCraft 520-8 on Windows 7x64

Please provide any additional information below.
Unsure if this feature is implemented already or if I maybe set it up wrong. As I could
find no info about this topic anywhere and tanks are trying to optimise damage (especially
10 man raids) i opened this issue.

Reported by stefan.winkler@gmx.li on 2013-05-05 11:19:54

navv1234 commented 9 years ago
Can you please attach the simc_gui.simc file found in your SimulationCraft folder?

If you're correctly set to role=tank you should get scale factors for parry & dodge.
For role=dps those might be deactivated.

Reported by philoptik on 2013-05-05 15:05:29

navv1234 commented 9 years ago
I attached the file. Seems like the Gui created the following line:
scale_only=none,str,agi,sta,int,spi,sp,ap,exp,hit,crit,haste,mastery,wdps,wspeed,wohdps,wohspeed,armor

Reported by stefan.winkler@gmx.li on 2013-05-05 16:27:20


navv1234 commented 9 years ago
if i manually add parry and dodge to the "scale_only=" line and run "simc.exe simc_gui.simc"
the scaling factors for dodge and parry are created. 

This is sufficient for my purposes but maybe not 100% intuitive.

Reported by stefan.winkler@gmx.li on 2013-05-05 16:35:31

navv1234 commented 9 years ago
So in other words the GUI doesn't support those scaling options. We'll fix that.

Reported by philoptik on 2013-05-05 18:26:02

navv1234 commented 9 years ago
You could try adding "scale_only=" ( with no arguments ) to the override tab in the
GUI, that way maybe all stats will be scaled. As a temporary solution.

Reported by philoptik on 2013-05-05 18:31:19

navv1234 commented 9 years ago
Fixed in r16525

Reported by philoptik on 2013-05-25 09:49:53