[Monk] Brewmaster several issues

[navv1234]

Originally reported on Google Code with ID 1777

Just ran a sim on my brewmaster monk to get an idea what the current result looks like.

Here are some observations:
Fight length = 540

Jab-count = 379,9 = 15196 energy what is way to much
No Blackout Kicks at all
No Tiger Palm at all
No Swift Reflexes at all - Might be because the monk in the sim is not being attacked

LVL30 talents seem to not be used - would expect to have chi wave being used nearly
on CD
LVL75 talents seem not to be used
LVL90 talents seem to not be used - for most fights that will be Xuen
There are Tiger Strikes, but those are WW only

Reported by d-oh2000@gmx.net on 2013-06-14 22:21:24

[navv1234]

You should get attacked when role=tank is specified ( default for brewmasters ). Swift
Reflexes retaliation is just not implemented.

Many Issues seem to be related to just not having the actions specified in the action
priority list. We currently do not have a good default one, if you have improvements,
feel free to share them with us.

Level 75 and 90 talents are not implemented.

Thanks for the information about Tiger Strikes - I'll disable them.

Stagger mechanics will be implemented as well. But after that, we'd really need a dedicated
Monk developer to give you everything you desire, and properly test everything.

Reported by philoptik on 2013-06-15 07:49:30

[navv1234]

level 90 talents are implemented ( have been for WW for a long time ), but are not used
in the default apl.

Not much missing anymore besides Purifying Brew, lvl75 talents, and maybe cleaning
up expel harm. And of course a lot of testing by someone actually actively playing
that class in raids.

Reported by philoptik on 2013-06-15 12:41:10

[navv1234]

I joined the project to help building a working brewmaster (and if needed windwalker)
sim. But as I am not used to coding, except building access-databases in vba, I will
not immediately be able to change the code to something that works better than the
existing. But I will try to provide any help I can.

Maybe a first step would be to have a better priority list.

Reported by d-oh2000@gmx.net on 2013-06-16 08:42:52

[navv1234]

Oh that's great news. I can certainly help with/do the remaining coding tasks.

For the default Action Priority List, the place for you to work would be in class_modules/sc_monk.cpp
monk_t::apl_combat_brewmaster(), around line 3180. The syntax is hopefully straightforward
enough. For the action expressions there's documentation in the Wiki.

Theck will soon start improving general tank metrics & analysis tools, which should
help brewmasters as well.

Reported by philoptik on 2013-06-16 11:15:28

[navv1234]

From my first tests setting up a Brewmaster-Default-Profile to be able to change things
faster for testing:
It seems that Jabs do not consume energy
Expel Harm seems to not consume energy and not trigger its 15sec CD
What are chi_from_avoided_attacks? 
Brewmasters can normally not start with 4 Chi
He does not cast a single chi wave.

Maybe I did something wrong? Here is my current priority list from the testing:
actions=auto_attack
actions+=/chi_sphere,if=talent.power_strikes.enabled&buff.chi_sphere.react&chi<4
actions+=/virmens_bite_potion,if=buff.bloodlust.react|target.time_to_die<=60
actions+=/chi_brew,if=talent.chi_brew.enabled&chi=0
actions+=/keg_smash,if=talent.ascension.enabled&chi<=3&cooldown.keg_smash.remains=0
actions+=/keg_smash,if=!talent.ascension.enabled&chi<=2&cooldown.keg_smash.remains=0
actions+=/tiger_palm,if=buff.tiger_power.remains<=3
actions+=/tiger_palm,if=buff.tiger_power.down&energy.time_to_max>1
actions+=/invoke_xuen,if=talent.invoke_xuen.enabled
actions+=/run_action_list,name=aoe,if=active_enemies>=5
actions+=/run_action_list,name=single_target,if=active_enemies<5

actions.aoe=rushing_jade_wind,if=talent.rushing_jade_wind.enabled
actions.aoe+=/spinning_crane_kick

actions.single_target=/chi_wave,if=talent.chi_wave.enabled&energy.time_to_max>2
actions.single_target+=/blackout_kick
actions.single_target+=/tiger_palm,if=energy.time_to_max>=2
# actions.single_target+=/expel_harm,if=talent.ascension.enabled&chi<=3&cooldown.expel_harm.remains=0
# actions.single_target+=/expel_harm,if=!talent.ascension.enabled&chi<=2&cooldown.expel_harm.remains=0
actions.single_target+=/jab,if=talent.ascension.enabled&chi<=3&(energy+(energy.regen*(cooldown.keg_smash.remains)))>=40
actions.single_target+=/jab,if=!talent.ascension.enabled&chi<=2&(energy+(energy.regen*(cooldown.keg_smash.remains)))>=40

Reported by d-oh2000@gmx.net on 2013-06-17 12:09:10

[navv1234]

What version are you using? Are you compiling from trunk, or using 530-3?
Jab energy consumption has only been recently fixed, and if you use a older version
this isn't included.

chi_from_avoided attacks seems to be chi refunding if you hit a enemy with a attack
that costs chi, but don't hit. See line 606 to 611 in sc_monk.cpp.

chi wave works fine if you have the talent enabled. Unfortunately I can't see your
whole input configuration,  but I assume that's the problem.

Expel harm having no cooldown is because the monk has <35% hp - he's a tank and gets
hit hard in the face, without a healer accompanying him.

I'll fix the initial chi. It should generally start at 0 unless you specify initial_chi=X
. Seems buged even for windwalkers.

Reported by philoptik on 2013-06-17 13:45:46

[navv1234]

I am currently using the normal downloadable version 530-3, as I need to get some additional
programs to work and test with the trunk.

chi_from_avoided_attacks is not applicable for brewmasters. blackoutkick always consumes
the 2 chi and always gives 6 seconds of shuffle, no matter if you hit the target or
not. rushing jade wind works the same. breath of fire also does not refund any chi.

expel harm - just saw the HP of the monk in the sim. it goes to 0 in a few sec and
stays there the rest of the fight. 

I will attach the full profile that I am currently using. It is a copy from the windwalker
file with some adjustments for brewmasters. 

Reported by d-oh2000@gmx.net on 2013-06-17 14:57:58

[navv1234]

My bad. Attached the wrong file. Created a new one to be able to have more crit in the
profile. You can find it attached.

Reported by d-oh2000@gmx.net on 2013-06-17 15:02:26

---

• _Attachment: Monk_Brewmaster_2h_T15N_crit.simc_

[navv1234]

Closing this because it's out of date for WoD. Open up a new ticket if there are still
issues.

Reported by s.alexlowery on 2014-07-21 01:27:15

• Status changed: Invalid