simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.4k stars 694 forks source link

Death Strike seems to do half damage for Blood DK as it is intended #2093

Closed navv1234 closed 9 years ago

navv1234 commented 9 years ago

Originally reported on Google Code with ID 2094

### Begin GUI options ###
item_db_source=local/bcpapi/wowhead/ptrhead/wodhead
iterations=10000
dps_plot_iterations=1000
default_world_lag=0.1
max_time=450
vary_combat_length=0.2
fight_style=Patchwerk
tmi_window_global=6
enemy=TMI_Standard_Boss_T17M
tmi_boss=T17M
role=tank
position=front
default_skill=1.0
optimal_raid=0
override.attack_power_multiplier=1
override.spell_power_multiplier=1
override.critical_strike=1
override.haste=1
override.multistrike=1
override.mastery=1
override.stamina=1
override.str_agi_int=1
override.versatility=1
override.bloodlust=1
override.bleeding=1
override.mortal_wounds=1
threads=2
thread_priority=Lower
scale_only=none
scale_over=TMI
dps_plot_stat=none
dps_plot_points=40
dps_plot_step=50
reforge_plot_stat=none
reforge_plot_amount=500
reforge_plot_step=50
statistics_level=1
### End GUI options ###
### Begin simulateText ###
deathknight="Death_Knight_Blood_T17M HASTE > MASTERY > VERS"
level=100
race=orc
role=tank
position=front
talents=http://us.battle.net/wow/en/tool/talent-calculator#da!1.000.1
glyphs=regenerative_magic/blood_boil
spec=blood

# This default action priority list is automatically created based on your character.
# It is a attempt to provide you with a action list that is both simple and practicable,
# while resulting in a meaningful and good simulation. It may not result in the absolutely
highest possible dps.
# Feel free to edit, adapt and improve it to your own needs.
# SimulationCraft is always looking for updates and improvements to the default action
lists.

# Executed before combat begins. Accepts non-harmful actions only.

actions.precombat=flask,type=greater_draenic_strength_flask
actions.precombat+=/food,type=talador_surf_and_turf
actions.precombat+=/blood_presence
actions.precombat+=/horn_of_winter
# Snapshot raid buffed stats before combat begins and pre-potting is done.
actions.precombat+=/snapshot_stats
actions.precombat+=/potion,name=draenic_armor_potion
actions.precombat+=/bone_shield

# Executed every time the actor is available.

actions=auto_attack
# if=time>10
actions+=/blood_fury
# if=time>10
actions+=/berserking
# if=time>10
actions+=/arcane_torrent
actions+=/potion,name=draenic_armor_potion,if=buff.potion.down&buff.blood_shield.down&!unholy&!frost
actions+=/antimagic_shell
actions+=/conversion,if=!buff.conversion.up&runic_power>50&health.pct<90
actions+=/death_strike,if=health.pct<50
actions+=/army_of_the_dead,if=buff.bone_shield.down&buff.dancing_rune_weapon.down&buff.icebound_fortitude.down&buff.vampiric_blood.down
actions+=/bone_shield,if=buff.army_of_the_dead.down&buff.bone_shield.down&buff.dancing_rune_weapon.down&buff.icebound_fortitude.down&buff.vampiric_blood.down
actions+=/vampiric_blood,if=health.pct<50
actions+=/icebound_fortitude,if=health.pct<30&buff.army_of_the_dead.down&buff.dancing_rune_weapon.down&buff.bone_shield.down&buff.vampiric_blood.down
actions+=/rune_tap,if=health.pct<50&buff.army_of_the_dead.down&buff.dancing_rune_weapon.down&buff.bone_shield.down&buff.vampiric_blood.down&buff.icebound_fortitude.down
actions+=/dancing_rune_weapon,if=health.pct<80&buff.army_of_the_dead.down&buff.icebound_fortitude.down&buff.bone_shield.down&buff.vampiric_blood.down
actions+=/death_pact,if=health.pct<50
actions+=/outbreak,if=(!talent.necrotic_plague.enabled&!disease.min_remains<8)|!disease.ticking
actions+=/death_coil,if=runic_power>90
actions+=/plague_strike,if=(!talent.necrotic_plague.enabled&!dot.blood_plague.ticking)|(talent.necrotic_plague.enabled&!dot.necrotic_plague.ticking)
actions+=/icy_touch,if=(!talent.necrotic_plague.enabled&!dot.frost_fever.ticking)|(talent.necrotic_plague.enabled&!dot.necrotic_plague.ticking)
actions+=/defile
actions+=/death_strike,if=(unholy=2|frost=2)
actions+=/death_coil,if=runic_power>70
actions+=/soul_reaper,if=target.health.pct-3*(target.health.pct%target.time_to_die)<=35&blood>=1
actions+=/blood_boil,if=blood=2
actions+=/blood_tap
actions+=/blood_boil
actions+=/death_coil
actions+=/plague_leech,if=(unholy=0|frost=0)
actions+=/empower_rune_weapon,if=!blood&!unholy&!frost

head=hardened_greathelm,id=113910,bonus_id=567
neck=choker_of_bestial_force,id=113952,bonus_id=567,enchant=gift_of_haste
shoulders=unstable_slag_shoulderplates,id=113884,bonus_id=567
back=ravenous_greatcloak,id=113883,bonus_id=567,enchant=gift_of_haste
chest=chestplate_of_rolling_fury,id=113881,bonus_id=567
wrists=bracers_of_martial_perfection,id=113871,bonus_id=567
hands=flamefury_gauntlets,id=113925,bonus_id=567
waist=uktars_belt_of_chiming_rings,id=113976,bonus_id=567
legs=firestorm_legplates,id=113921,bonus_id=567
feet=sabatons_of_fractal_earth,id=113936,bonus_id=567
finger1=spellbound_runic_band_of_elemental_invincibility,id=118308,enchant=gift_of_haste
finger2=seal_of_unquenchable_flame,id=113922,bonus_id=567,enchant=gift_of_haste
trinket1=blast_furnace_door,id=113893,bonus_id=567
trinket2=pols_blinded_eye,id=113834,bonus_id=567
main_hand=thogars_control_rod,id=113953,bonus_id=567,enchant=rune_of_the_fallen_crusader

### End simulateText ###
### Begin overrides ###
# User-specified persistent global and player parms will set here.
### End overrides ###
### Begin command line ###

### End command line ###
### Begin final options ###
### End final options ###
### END ###

What steps will reproduce the problem?
1. Run any sim with Blood; Death Strike damage per execution time is far lower then
on beta for the same gear. I believe the issue is that the 100% damage bonus to Death
Strike from Veteran of the Third War isn't being taken into account.

What is the expected output? What do you see instead?

Death Strike damage per execution time should be considerably higher then it currently
is.

What version of the product are you using? On what operating system?

Win 64 bit.

Please provide any additional information below.

Reported by troxismwow on 2014-09-26 00:54:06

navv1234 commented 9 years ago
This issue was closed by revision fa5520885f1e.

Reported by navv1234 on 2014-09-26 08:47:28