simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.41k stars 697 forks source link

Arms Warrior - Haste Highly Overvalued #2294

Closed navv1234 closed 9 years ago

navv1234 commented 9 years ago

Originally reported on Google Code with ID 2295

IF RUNNING FROM THE GUI, PLEASE ATTACH (or Cut-N-Paste contents) OF
simc_gui.simc FILE.  THIS WILL ENABLE TO US TO REPRODUCE THE PROBLEM.

What steps will reproduce the problem?
1. Running DPS and scaling simulations for an Arms warrior. I haven't tested Prot or
Fury. Haste plot is included in the results that I attached.

What is the expected output? What do you see instead?
Haste should not be valued THAT much more than versatility, mastery, and crit. On prior
releases, haste was valued second to last with only multi-strike being worse than it.

What version of the product are you using? On what operating system?
603-10, Windows 7 x64

Please provide any additional information below.
I believe haste being valued this high is indeed a bug. If you look at the haste plot,
it's all over the place.

Reported by jason.margeotes on 2014-12-21 21:38:37


navv1234 commented 9 years ago
EDIT: Typo.. Should be version 603-19 - not 603-10

Reported by jason.margeotes on 2014-12-22 04:56:35

navv1234 commented 9 years ago
There is no bug, you enabled pvp mode. In PVP, Crit's only hit for 150% instead of 200%,
and multistrikes only roll once, instead of twice.

Reported by s.alexlowery on 2014-12-22 07:13:43

navv1234 commented 9 years ago
The oddities of the haste graph are due to breakpoints inside of colossus smash. At
certain levels of haste (I forgot the exact %), there can be one additional ability
placed inside of colossus smash.

Reported by s.alexlowery on 2014-12-22 07:18:43

navv1234 commented 9 years ago
If you run the same simulation on an older version (15) with the same gear and setup
you'll see that haste is where it should be - near the bottom. I know that rotations
and ability priorities change between versions, but there's not much of a difference
for arms between 15 and 19. I made sure to include Bladestorm in the single target
rotation because I believe it may have not been in there and that was the biggest difference.
PvP mode was purposely enabled since all I do is PvP. I used Helter Skeltor for the
same reason. With a lower uptime on the target, there's no way haste pulls that far
ahead. Both mastery and versatility should be far ahead of it. I'll look into the haste
breakpoint you need in order to fit another ability inside your colossus smash. Regardless,
I still believe something is awry.

Reported by jason.margeotes on 2014-12-22 07:32:46

navv1234 commented 9 years ago
Is haste the best stat all the time? Very likely not. 

It appears that your character just happens to have the perfect amount of haste to
inflate the value of haste. All we do to calculate stat weights is add 350 of a stat
to what you currently have, calculate dps, and then divide the difference by the amount
of stat added. So if I add 350 haste and it gains 350 dps, each point of haste is worth
1 dps. Breakpoints like this can really screw with it, so we need to use another tool,
the reforge plot. 

In the attached picture, I simulated your character and did what's known as a reforge
plot. This plot just adds a small amount of one stat, then subtracts a small amount
of another. It can give some insight on breakpoints.

So, in the example. If you move from the left side of the picture, to the right side
of the picture, the extreme left hand side is your character with -500 haste and +500
mastery. The middle (0,0) is where your character is now. As you can see, around +100
haste/-100 mastery, there is a gigantic leap in dps from adding haste. 

This gigantic leap is right around 9% haste for your character, since you aren't using
a raid buff for haste. Then, you'll notice that haste falls back in it's normal super-crappy
place, as mastery is much better.

What happens around 9% haste that makes the value skyrocket? It's difficult to say,
and would require some investigation to find out. However, if I manually add in 200
haste so that this breakpoint is of no concern, I get the following stat weights:

Str: 3.09
Versatility: 1.23
Mastery: 1.22
Crit: 1.01
Multistrike: 0.74
Haste: 0.41

Which is what you were seeing before. :)

Also, as mentioned in https://code.google.com/p/simulationcraft/issues/detail?id=2245
we don't have a way to scale pvp items up to 675. The only way to do so is to add ,ilevel=675
to each item, and that's what I did in these examples. 

Example with your character:
head=primal_combatants_plate_helm,id=115168,ilevel=675
neck=primal_gladiators_choker_of_cruelty,id=115734,enchant=40mastery,ilevel=675
shoulders=primal_combatants_plate_shoulders,id=115170,bonus_id=547,ilevel=675
back=primal_combatants_cloak_of_cruelty,id=115189,enchant=100mastery,ilevel=675
chest=primal_gladiators_plate_chestpiece,id=115766,ilevel=675,gems=150haste
shirt=stylish_black_shirt,id=3427
wrists=primal_combatants_armplates_of_prowess,id=115116,ilevel=675
hands=primal_combatants_plate_gauntlets,id=115142,ilevel=675
waist=primal_combatants_girdle_of_cruelty,id=115111,ilevel=675
legs=primal_combatants_plate_legguards,id=115169,ilevel=675
feet=primal_combatants_warboots_of_cruelty,id=115113,ilevel=675
finger1=primal_combatants_signet_of_accuracy,id=115172,enchant=30mastery,ilevel=675
finger2=primal_combatants_signet_of_cruelty,id=115146,enchant=30mastery,ilevel=675
trinket1=primal_combatants_medallion_of_cruelty,id=115156,ilevel=675
trinket2=primal_combatants_insignia_of_victory,id=115160,ilevel=675
main_hand=primal_combatants_bonegrinder,id=120075,bonus_id=547,enchant=mark_of_the_shattered_hand,ilevel=675

Reported by s.alexlowery on 2014-12-22 11:51:40


navv1234 commented 9 years ago

Reported by s.alexlowery on 2014-12-24 18:42:35