search

simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.42k stars 701 forks source link

[Paladin] Judgement not generating Holy Power #2414

Closed navv1234 closed 9 years ago

navv1234 commented 9 years ago

Originally reported on Google Code with ID 2415

IF RUNNING FROM THE GUI, PLEASE ATTACH (or Cut-N-Paste contents) OF
simc_gui.simc FILE.  THIS WILL ENABLE TO US TO REPRODUCE THE PROBLEM.

What steps will reproduce the problem?
Run the simulation with the default settings for https://eu.battle.net/wow/character/ghostlands/Arborel/advanced

What is the expected output?
The Judgement spell (spelt Judgment in simc) should generate Holy Power for protection
spec paladins

What do you see instead?
No holy power from judgement on this character. 

What version of the product are you using? On what operating system?
simc-603-24-win64
Windows 7

Please provide any additional information below.
This defect does not seem to affect EVERY character. E.g. It works fine for http://eu.battle.net/wow/en/character/pozzo-delleternita/Liira/simple

Perhaps a main spec/off spec issue?

### Begin GUI options ###
ptr=0
item_db_source=local/bcpapi/wowhead/ptrhead
target_error=0
iterations=10000
default_world_lag=0.20
max_time=450
vary_combat_length=0.2
fight_style=Patchwerk
tmi_window_global=6
target_level+=3
target_race=Humanoid
default_skill=0.75
optimal_raid=0
override.attack_power_multiplier=1
override.spell_power_multiplier=1
override.critical_strike=1
override.haste=1
override.multistrike=1
override.mastery=1
override.stamina=1
override.str_agi_int=1
override.versatility=1
override.bloodlust=0
override.bleeding=1
override.mortal_wounds=1
threads=4
thread_priority=Lowest
scale_over=TMI
reforge_plot_stat=none
reforge_plot_amount=500
reforge_plot_step=50
statistics_level=1
### End GUI options ###
### Begin simulateText ###
paladin="Arborel_Active"
origin="https://eu.api.battle.net/wow/character/ghostlands/Arborel/advanced"
thumbnail="http://eu.battle.net/static-render/eu/ghostlands/168/7922088-avatar.jpg"
level=100
race=blood_elf
role=tank
position=front
professions=jewelcrafting=143/mining=640
talents=http://eu.battle.net/wow/en/tool/talent-calculator#bZ!1021212
glyphs=focused_shield/divine_protection/alabaster_shield
spec=protection

# This default action priority list is automatically created based on your character.
# It is a attempt to provide you with a action list that is both simple and practicable,
# while resulting in a meaningful and good simulation. It may not result in the absolutely
highest possible dps.
# Feel free to edit, adapt and improve it to your own needs.
# SimulationCraft is always looking for updates and improvements to the default action
lists.

# Executed before combat begins. Accepts non-harmful actions only.

actions.precombat=flask,type=greater_draenic_stamina_flask
actions.precombat+=/food,type=talador_surf_and_turf
actions.precombat+=/blessing_of_kings,if=(!aura.str_agi_int.up)&(aura.mastery.up)
actions.precombat+=/blessing_of_might,if=!aura.mastery.up
actions.precombat+=/seal_of_insight
actions.precombat+=/sacred_shield
# Snapshot raid buffed stats before combat begins and pre-potting is done.
actions.precombat+=/snapshot_stats
actions.precombat+=/potion,name=draenic_armor

# Executed every time the actor is available.

actions=auto_attack
actions+=/speed_of_light,if=movement.remains>1
actions+=/blood_fury
actions+=/berserking
actions+=/arcane_torrent
# This line will shortcut to a high-DPS (but low-survival) action list. Change 0 to
1 if you want to do this all the time.
actions+=/run_action_list,name=max_dps,if=role.attack|0
# This line will shortcut to a high-survival (but low-DPS) action list. Change 0 to
1 if you want it to do this all the time.
actions+=/run_action_list,name=max_survival,if=0
actions+=/potion,name=draenic_armor,if=buff.shield_of_the_righteous.down&buff.seraphim.down&buff.divine_protection.down&buff.guardian_of_ancient_kings.down&buff.ardent_defender.down
# Standard survival priority list starts here
# This section covers off-GCD spells.
actions+=/holy_avenger
actions+=/seraphim
actions+=/divine_protection,if=time<5|!talent.seraphim.enabled|(buff.seraphim.down&cooldown.seraphim.remains>5&cooldown.seraphim.remains<9)
actions+=/guardian_of_ancient_kings,if=time<5|(buff.holy_avenger.down&buff.shield_of_the_righteous.down&buff.divine_protection.down)
actions+=/ardent_defender,if=time<5|(buff.holy_avenger.down&buff.shield_of_the_righteous.down&buff.divine_protection.down&buff.guardian_of_ancient_kings.down)
actions+=/eternal_flame,if=buff.eternal_flame.remains<2&buff.bastion_of_glory.react>2&(holy_power>=3|buff.divine_purpose.react|buff.bastion_of_power.react)
actions+=/eternal_flame,if=buff.bastion_of_power.react&buff.bastion_of_glory.react>=5
actions+=/harsh_word,if=glyph.harsh_words.enabled&holy_power>=3
actions+=/shield_of_the_righteous,if=buff.divine_purpose.react
actions+=/shield_of_the_righteous,if=(holy_power>=5|incoming_damage_1500ms>=health.max*0.3)&(!talent.seraphim.enabled|cooldown.seraphim.remains>5)
actions+=/shield_of_the_righteous,if=buff.holy_avenger.remains>time_to_hpg&(!talent.seraphim.enabled|cooldown.seraphim.remains>time_to_hpg)
# GCD-bound spells start here
actions+=/seal_of_insight,if=talent.empowered_seals.enabled&!seal.insight&buff.uthers_insight.remains<cooldown.judgment.remains
actions+=/seal_of_righteousness,if=talent.empowered_seals.enabled&!seal.righteousness&buff.uthers_insight.remains>cooldown.judgment.remains&buff.liadrins_righteousness.down
actions+=/seal_of_truth,if=talent.empowered_seals.enabled&!seal.truth&buff.uthers_insight.remains>cooldown.judgment.remains&buff.liadrins_righteousness.remains>cooldown.judgment.remains&buff.maraads_truth.down
actions+=/avengers_shield,if=buff.grand_crusader.react&active_enemies>1&!glyph.focused_shield.enabled
actions+=/hammer_of_the_righteous,if=active_enemies>=3
actions+=/crusader_strike
actions+=/wait,sec=cooldown.crusader_strike.remains,if=cooldown.crusader_strike.remains>0&cooldown.crusader_strike.remains<=0.35
actions+=/judgment,cycle_targets=1,if=glyph.double_jeopardy.enabled&last_judgment_target!=target
actions+=/judgment
actions+=/wait,sec=cooldown.judgment.remains,if=cooldown.judgment.remains>0&cooldown.judgment.remains<=0.35
actions+=/avengers_shield,if=active_enemies>1&!glyph.focused_shield.enabled
actions+=/holy_wrath,if=talent.sanctified_wrath.enabled
actions+=/avengers_shield,if=buff.grand_crusader.react
actions+=/sacred_shield,if=target.dot.sacred_shield.remains<2
actions+=/holy_wrath,if=glyph.final_wrath.enabled&target.health.pct<=20
actions+=/avengers_shield
actions+=/lights_hammer,if=!talent.seraphim.enabled|buff.seraphim.remains>10|cooldown.seraphim.remains<6
actions+=/holy_prism,if=!talent.seraphim.enabled|buff.seraphim.up|cooldown.seraphim.remains>5|time<5
actions+=/consecration,if=target.debuff.flying.down&active_enemies>=3
actions+=/execution_sentence,if=!talent.seraphim.enabled|buff.seraphim.up|time<12
actions+=/hammer_of_wrath
actions+=/sacred_shield,if=target.dot.sacred_shield.remains<8
actions+=/consecration,if=target.debuff.flying.down
actions+=/holy_wrath
actions+=/seal_of_insight,if=talent.empowered_seals.enabled&!seal.insight&buff.uthers_insight.remains<=buff.liadrins_righteousness.remains&buff.uthers_insight.remains<=buff.maraads_truth.remains
actions+=/seal_of_righteousness,if=talent.empowered_seals.enabled&!seal.righteousness&buff.liadrins_righteousness.remains<=buff.uthers_insight.remains&buff.liadrins_righteousness.remains<=buff.maraads_truth.remains
actions+=/seal_of_truth,if=talent.empowered_seals.enabled&!seal.truth&buff.maraads_truth.remains<buff.uthers_insight.remains&buff.maraads_truth.remains<buff.liadrins_righteousness.remains
actions+=/sacred_shield
actions+=/flash_of_light,if=talent.selfless_healer.enabled&buff.selfless_healer.stack>=3

actions.max_dps=potion,name=draenic_armor,if=buff.holy_avenger.react|buff.bloodlust.react|target.time_to_die<=60
# Max-DPS priority list starts here.
# This section covers off-GCD spells.
actions.max_dps+=/holy_avenger
actions.max_dps+=/seraphim
actions.max_dps+=/shield_of_the_righteous,if=buff.divine_purpose.react
actions.max_dps+=/shield_of_the_righteous,if=(holy_power>=5|talent.holy_avenger.enabled)&(!talent.seraphim.enabled|cooldown.seraphim.remains>5)
actions.max_dps+=/shield_of_the_righteous,if=buff.holy_avenger.remains>time_to_hpg&(!talent.seraphim.enabled|cooldown.seraphim.remains>time_to_hpg)
# #GCD-bound spells start here.
actions.max_dps+=/avengers_shield,if=buff.grand_crusader.react&active_enemies>1&!glyph.focused_shield.enabled
actions.max_dps+=/holy_wrath,if=talent.sanctified_wrath.enabled&(buff.seraphim.react|(glyph.final_wrath.enabled&target.health.pct<=20))
actions.max_dps+=/hammer_of_the_righteous,if=active_enemies>=3
actions.max_dps+=/judgment,if=talent.empowered_seals.enabled&(buff.maraads_truth.down|buff.liadrins_righteousness.down)
actions.max_dps+=/crusader_strike
actions.max_dps+=/wait,sec=cooldown.crusader_strike.remains,if=cooldown.crusader_strike.remains>0&cooldown.crusader_strike.remains<=0.35
actions.max_dps+=/judgment,cycle_targets=1,if=glyph.double_jeopardy.enabled&last_judgment_target!=target
actions.max_dps+=/judgment
actions.max_dps+=/wait,sec=cooldown.judgment.remains,if=cooldown.judgment.remains>0&cooldown.judgment.remains<=0.35
actions.max_dps+=/avengers_shield,if=active_enemies>1&!glyph.focused_shield.enabled
actions.max_dps+=/holy_wrath,if=talent.sanctified_wrath.enabled
actions.max_dps+=/avengers_shield,if=buff.grand_crusader.react
actions.max_dps+=/execution_sentence,if=active_enemies<3
actions.max_dps+=/holy_wrath,if=glyph.final_wrath.enabled&target.health.pct<=20
actions.max_dps+=/avengers_shield
actions.max_dps+=/seal_of_truth,if=talent.empowered_seals.enabled&!seal.truth&buff.maraads_truth.remains<cooldown.judgment.remains
actions.max_dps+=/seal_of_righteousness,if=talent.empowered_seals.enabled&!seal.righteousness&buff.maraads_truth.remains>cooldown.judgment.remains&buff.liadrins_righteousness.down
actions.max_dps+=/lights_hammer
actions.max_dps+=/holy_prism
actions.max_dps+=/consecration,if=target.debuff.flying.down&active_enemies>=3
actions.max_dps+=/execution_sentence
actions.max_dps+=/hammer_of_wrath
actions.max_dps+=/consecration,if=target.debuff.flying.down
actions.max_dps+=/holy_wrath
actions.max_dps+=/seal_of_truth,if=talent.empowered_seals.enabled&!seal.truth&buff.maraads_truth.remains<buff.liadrins_righteousness.remains
actions.max_dps+=/seal_of_righteousness,if=talent.empowered_seals.enabled&!seal.righteousness&buff.liadrins_righteousness.remains<buff.maraads_truth.remains
actions.max_dps+=/sacred_shield
actions.max_dps+=/flash_of_light,if=talent.selfless_healer.enabled&buff.selfless_healer.stack>=3

actions.max_survival=potion,name=draenic_armor,if=buff.shield_of_the_righteous.down&buff.seraphim.down&buff.divine_protection.down&buff.guardian_of_ancient_kings.down&buff.ardent_defender.down
# Max survival priority list starts here
# This section covers off-GCD spells.
actions.max_survival+=/holy_avenger
actions.max_survival+=/divine_protection,if=time<5|!talent.seraphim.enabled|(buff.seraphim.down&cooldown.seraphim.remains>5&cooldown.seraphim.remains<9)
actions.max_survival+=/seraphim,if=buff.divine_protection.down&cooldown.divine_protection.remains>0
actions.max_survival+=/guardian_of_ancient_kings,if=buff.holy_avenger.down&buff.shield_of_the_righteous.down&buff.divine_protection.down
actions.max_survival+=/ardent_defender,if=buff.holy_avenger.down&buff.shield_of_the_righteous.down&buff.divine_protection.down&buff.guardian_of_ancient_kings.down
actions.max_survival+=/eternal_flame,if=buff.eternal_flame.remains<2&buff.bastion_of_glory.react>2&(holy_power>=3|buff.divine_purpose.react|buff.bastion_of_power.react)
actions.max_survival+=/eternal_flame,if=buff.bastion_of_power.react&buff.bastion_of_glory.react>=5
actions.max_survival+=/shield_of_the_righteous,if=buff.divine_purpose.react
actions.max_survival+=/shield_of_the_righteous,if=(holy_power>=5|incoming_damage_1500ms>=health.max*0.3)&(!talent.seraphim.enabled|cooldown.seraphim.remains>5)
actions.max_survival+=/shield_of_the_righteous,if=buff.holy_avenger.remains>time_to_hpg&(!talent.seraphim.enabled|cooldown.seraphim.remains>time_to_hpg)
actions.max_survival+=/hammer_of_the_righteous,if=active_enemies>=3
actions.max_survival+=/crusader_strike
actions.max_survival+=/wait,sec=cooldown.crusader_strike.remains,if=cooldown.crusader_strike.remains>0&cooldown.crusader_strike.remains<=0.35
actions.max_survival+=/judgment,cycle_targets=1,if=glyph.double_jeopardy.enabled&last_judgment_target!=target
actions.max_survival+=/judgment
actions.max_survival+=/wait,sec=cooldown.judgment.remains,if=cooldown.judgment.remains>0&cooldown.judgment.remains<=0.35
actions.max_survival+=/avengers_shield,if=buff.grand_crusader.react&active_enemies>1
actions.max_survival+=/holy_wrath,if=talent.sanctified_wrath.enabled
actions.max_survival+=/avengers_shield,if=buff.grand_crusader.react
actions.max_survival+=/sacred_shield,if=target.dot.sacred_shield.remains<2
actions.max_survival+=/avengers_shield
actions.max_survival+=/lights_hammer
actions.max_survival+=/holy_prism
actions.max_survival+=/consecration,if=target.debuff.flying.down&active_enemies>=3
actions.max_survival+=/execution_sentence
actions.max_survival+=/flash_of_light,if=talent.selfless_healer.enabled&buff.selfless_healer.stack>=3
actions.max_survival+=/hammer_of_wrath
actions.max_survival+=/sacred_shield,if=target.dot.sacred_shield.remains<8
actions.max_survival+=/holy_wrath,if=glyph.final_wrath.enabled&target.health.pct<=20
actions.max_survival+=/consecration,if=target.debuff.flying.down&!ticking
actions.max_survival+=/holy_wrath
actions.max_survival+=/sacred_shield

head=crown_of_the_crags,id=116237
neck=fistbreak_choker,id=109965,bonus_id=524
shoulders=verdant_plate_spaulders,id=109944,bonus_id=499/524
back=flamescarred_drape,id=116298
chest=chestplate_of_destructive_resonance,id=116235
wrists=bracers_of_cursed_cries,id=116234,bonus_id=560
hands=grips_of_burning_infusion,id=116233
waist=incarnadine_girdle,id=109837,bonus_id=524
legs=verdant_plate_legguards,id=109819,bonus_id=523/524,gems=35haste
feet=ogreeater_treads,id=116230
finger1=band_of_the_stalwart_stanchion,id=109783,bonus_id=524
finger2=seal_of_resilient_fortitude,id=109776,bonus_id=524
trinket1=torias_unseeing_eye,id=110015,bonus_id=524
trinket2=idol_of_suppression,id=116293,bonus_id=563,gems=35haste
main_hand=butchers_cruel_chopper,id=116361
off_hand=draconian_doomshield,id=118739,bonus_id=524

# Gear Summary
# gear_strength=1737
# gear_stamina=2604
# gear_crit_rating=705
# gear_haste_rating=524
# gear_mastery_rating=560
# gear_armor=2630
# gear_bonus_armor=577
# gear_multistrike_rating=467
# gear_versatility_rating=161

### End simulateText ###
### Begin overrides ###
# User-specified persistent global and player parameters will be set here.

### End overrides ###
### Begin command line ###

### End command line ###
### Begin final options ###
### End final options ###
### END ###

Reported by man.kurm.lee on 2015-01-30 09:33:16

navv1234 commented 9 years ago

Reported by s.alexlowery on 2015-01-30 13:16:03

navv1234 commented 9 years ago 
Looks like there's a code logic error that skips the holy power generation if the player
is using long arm of the law. fixed here:
https://code.google.com/p/simulationcraft/source/detail?r=d63fd56a70ed90463261233e3fd60b746230ddbc

Reported by s.alexlowery on 2015-01-30 13:32:38