simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.39k stars 693 forks source link

With 4 targets selected I get very low DPS with 3 or less High DPS. (Death Knight) #2476

Closed navv1234 closed 9 years ago

navv1234 commented 9 years ago

Originally reported on Google Code with ID 2477

What steps will reproduce the problem?
1.Import my toon http://eu.battle.net/wow/en/character/shadowsong/Adam/simple
2.Set number of enemy's to 4
3.Set world lag to <50
4. Scale factors ticked and tick Str,AP,Mast,Multi,Vers,Haste,Crit
5. Run sim.

What is the expected output? What do you see instead?
I see 21k DPS overall and 8k to main target. If i select only 1-3 enemy's i will get
over 35k DPS easy. Should be seeing well over 50k for overall and 35k ish for main
target. 

What version of the product are you using? On what operating system?
Latest. 610-05

Please provide any additional information below.
If needed you can contact me on mmo champ (http://www.mmo-champion.com/members/959200-Hugh-Wattmate),
sonoflich.com chat (HughWattMate) or MMO-Champ IRC (HughWattmate) 

Reported by adamvester on 2015-03-06 09:52:53


navv1234 commented 9 years ago
Looking at results it has not taken in account NP damage.

Reported by adamvester on 2015-03-06 10:18:06

navv1234 commented 9 years ago
It's an action list thing. The character is sitting idle 90% of the time. I'll see what
line is tripping it up.

Reported by s.alexlowery on 2015-03-06 10:54:16

navv1234 commented 9 years ago
Change this line:
actions.aoe+=/run_action_list,name=spread,if=!dot.blood_plague.ticking|!dot.frost_fever.ticking|(!dot.necrotic_plague.ticking&talent.necrotic_plague.enabled)

to

actions.aoe+=/call_action_list,name=spread,if=!dot.blood_plague.ticking|!dot.frost_fever.ticking|(!dot.necrotic_plague.ticking&talent.necrotic_plague.enabled)

Just swappnig run_action_list for call_action_list... I think that line used call action
list forever ago, and was switched at some point. 

Reported by s.alexlowery on 2015-03-06 11:32:10

navv1234 commented 9 years ago
https://code.google.com/p/simulationcraft/source/detail?r=c27ead57d76206a32d0f240d06f8575a962a132b

Reported by s.alexlowery on 2015-03-06 11:39:33

navv1234 commented 9 years ago
ah thanks very much for the reply will do :)

Reported by adamvester on 2015-03-06 11:46:59

navv1234 commented 9 years ago
changed all to from run_action to call_action still NP wont show on results :( 

Reported by adamvester on 2015-03-06 12:00:41

navv1234 commented 9 years ago
Only change that one line, not all of them.

Necrotic plague was showing up on your original log, it just doesn't show up in the
"Damage per execute time" thing.

http://collision.heroicstrike.org/2015-03-06_07-40-04.png

Reported by s.alexlowery on 2015-03-06 12:40:45