simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.38k stars 691 forks source link

[DK] Alternative APL for BDK #2503

Closed navv1234 closed 9 years ago

navv1234 commented 9 years ago

Originally reported on Google Code with ID 2504

Attached profile for BDK with APL for Breath of Sindragosa.
Mey be this APL can add like second profile BDK.

simulation result:
Death_Knight_Blood_T17M_BoS : 53620 dps, 56811 dtps, 58809 hps (21022 aps), 160.4k
TMI, 158.9k ETMI

Reported by Quaid007 on 2015-03-24 00:00:43


navv1234 commented 9 years ago
I'll add it to the raid reports, however, it really needs to be cleaned up a little
before I can add it as a default action list. 

ex:

actions.bos+=/death_strike,if=buff.blood_charge.stack>=11
actions.bos+=/death_strike,if=runic_power<80&blood.frac>1.8&blood.death>=1
actions.bos+=/death_strike,if=runic_power<80&frost.frac>1.8
actions.bos+=/death_strike,if=runic_power<80&unholy.frac>1.8

Just find a way to combine those lines if possible. If not, that's fine, I'll eventually
code it in. But for now, I'm just copy/pasting the profile.

Reported by s.alexlowery on 2015-03-24 06:41:24

navv1234 commented 9 years ago
I'm also not getting 53k dps from that, what settings are you using ?

Reported by s.alexlowery on 2015-03-24 06:44:25

navv1234 commented 9 years ago
Before used build:
SimulationCraft 610-08
for World of Warcraft 6.1.0 Live (build level 19702)

with options:
http://s2.1pic.org/files/2015/03/24/8c5b404a45dd234f2f07.jpg

Attached previous html-file of simulation result.

But in new build 612-01 something happen with BoS uptime.
I will try to investigate it.

Reported by Quaid007 on 2015-03-24 11:40:51


navv1234 commented 9 years ago
Now something wrong with BoS runic power cost.
Every second double subtraction 15 RP.

Attach new file of results.
Breath of Sindragosa  tick count 44.3
Resource Usage  breath_of_sindragosa count 84.3

Reported by Quaid007 on 2015-03-24 12:28:14


navv1234 commented 9 years ago
I think need check this:
https://code.google.com/p/simulationcraft/source/detail?r=335d11380e6d2a17c01678e7cc71529a60ee206f
or this commit:
https://code.google.com/p/simulationcraft/source/detail?r=70151cd469bd309d826f995d33a4cd6cc186a03d

Reported by Quaid007 on 2015-03-24 13:01:39

navv1234 commented 9 years ago
Ah, yes. We added in a method that would automatically deal with spells that consume
resources per second, so that we would no longer need to do it manually. I'll fix it
for DKs.

Reported by s.alexlowery on 2015-03-24 19:43:38

navv1234 commented 9 years ago
I fixed that, but there are other issues. It's doing far too much damage, when compared
to logs. We're looking into it though.

Blood DKs definitely do a lot of damage with this talent, but not quite that much.

Reported by s.alexlowery on 2015-03-24 22:11:45

navv1234 commented 9 years ago
Ok, navv found an attack power snapshot issue, it was snapshotting 19k AP on Breath
the entire encounter. It should be good to go now. 

If you can clean up the action list, I'll add it in as a default for people to import
their character with. 

Reported by s.alexlowery on 2015-03-24 22:25:16

navv1234 commented 9 years ago
Ok, I try to clean up and combine lines.
And try make more generic APL, because now APL based on specific glyphs/talents for
best BoS uptime. 
Imported characters can have just BoS talent.

Reported by Quaid007 on 2015-03-25 00:31:14

navv1234 commented 9 years ago
Current testing build:
SimcSetup-612-01-Win64.exe   25-Mar-2015 06:54
Ticks of breath_of_sindragosa 446.64
Resource usage breath_of_sindragosa  count 107.3
But must be same number.

Reported by Quaid007 on 2015-03-25 08:12:23

navv1234 commented 9 years ago
runic power timeline
http://s2.1pic.org/files/2015/03/25/29804cba37e446948c57.jpg

Reported by Quaid007 on 2015-03-25 08:16:55

navv1234 commented 9 years ago
Build: SimcSetup-612-01-Win64.exe 25-Mar-2015 10:32
[Bug]Blood Charge not generate when Runic Power spend on BoS.

Reported by Quaid007 on 2015-03-25 10:22:54

navv1234 commented 9 years ago
More regressions from the recent conversion of cost/second stuff. I fixed the blood
charge thing (and the other rp-cost related triggers). That runic power tick vs consumption
thing needs to be looked at some.

Reported by navv1234 on 2015-03-25 20:26:36

navv1234 commented 9 years ago
new profile

Reported by Quaid007 on 2015-03-29 07:48:15


navv1234 commented 9 years ago
I  will make sure to put the new(est) profile in before we release the next version.
I've been a bit busy lately, but I'll make sure it gets in.

Reported by s.alexlowery on 2015-03-30 01:44:43

navv1234 commented 9 years ago
Ok thanks, I improved previous version.
And I divided spell usage for different trinkets.

Uncommented line used in default profile.
Commented line used for people to import with other trinkets.

Add section comments like this:
#####BEGIN: for  blast_furnace_door,id=113893

Reported by Quaid007 on 2015-03-30 10:07:07


navv1234 commented 9 years ago
Ok added it in to the action list generation.

Reported by s.alexlowery on 2015-04-02 07:09:00

navv1234 commented 9 years ago

Reported by s.alexlowery on 2015-04-11 01:19:04