simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.41k stars 697 forks source link

Gladiators Resolve for Protection Warriors granting ~10% damage #2606

Closed navv1234 closed 9 years ago

navv1234 commented 9 years ago

Originally reported on Google Code with ID 2607

IF RUNNING FROM THE GUI, PLEASE ATTACH (or Cut-N-Paste contents) OF
simc_gui.simc FILE.  THIS WILL ENABLE TO US TO REPRODUCE THE PROBLEM.

What steps will reproduce the problem?
1. Simulate protection warrior with talent 'Ravager'
2. Simulate same warrior with talent 'Gladiators Resolve'

What is the expected output? What do you see instead?

Expected: 'Ravager' should lead to more DPS (does damage itself + parries proc revenge)
Actual: 'Gladiators Resolve' has way higher DPS (about 10%), the 10% increase seems
to be distributed evenly across all abilities

What version of the product are you using? On what operating system?
620-02, Windows 8.1 64bit

Please provide any additional information below.

Reported by mader.raphael on 2015-07-30 22:01:42

navv1234 commented 9 years ago
This is intentional. There is no way of knowing 100% whether or not someone wants to
simulate gladiator dps or gladiator tank when imported. So, I added in a few checks.

Basically, it assumes you are gladiator dps until you fail one of the following checks:

Gladiator's Resolve not talented --> It's a tank.
The role is set specifically to Tank ---> It's a tank.
They are using Mark of Blackrock weapon enchant --> It's a tank.
The next check cycles through trinkets to see if any of them have Stamina, if they
do, it's a tank.

If all of those checks pass, it will import you as a dps and you will do more damage
simply because you are in gladiator stance and you are using rage for damage, not defense.

If you change the role in the gui from auto to tank, it will fix it.

Reported by s.alexlowery on 2015-07-31 00:17:18

navv1234 commented 9 years ago
Thanks for your quick reply - I am aware of the defaulting behaviour for Gladiator's
resolve.

Both tests were done with role=tank and the same action lists:

Ravager: http://pastebin.com/TfvqEjYW - ~35880 DPS
Gladiator's Resolve: http://pastebin.com/HeK24jpp - ~38851 DPS

Gladiator's Resolve is still ahead about 10% (distributed very consistently across
all abilities).

Reported by mader.raphael on 2015-07-31 08:53:45

navv1234 commented 9 years ago
I'll check it out, that's a bit strange.

Reported by s.alexlowery on 2015-07-31 17:12:37

navv1234 commented 9 years ago
I think someone mentioned that the mastery bonus to gladiator warriors in 6.2 is also
being applied to protection warriors in simc.

Reported by Kungersma on 2015-08-04 09:05:39

navv1234 commented 9 years ago
Thanks, fixed.

https://code.google.com/p/simulationcraft/source/detail?r=5527eebd931ab6420cb68d4007aedff0b64bcc10

Reported by s.alexlowery on 2015-08-05 03:25:05