search

simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.41k stars 697 forks source link

Warlock DPS calculations are wrong #276

Closed navv1234 closed 9 years ago

navv1234 commented 9 years ago

Originally reported on Google Code with ID 277

What steps will reproduce the problem?
1. load a warlock profile from wowarmory
2. run a simulation

What is the expected output? What do you see instead?
Supposed to see the correct spellpower, hit, haste, crit, etc. Calculations
are all wrong. All stats, buffs, etc are done wrong. 
Thus, the dps predicted is totally wrong.

What version of the product are you using? On what operating system?
simc-333-0-win32

Windows Vista 64bit

Reported by didomen58 on 2010-03-24 23:35:57

navv1234 commented 9 years ago 
I can confirm the problem. When I save the profile it will pull the items, enchants
and gems, but not the stats of the items and the result looks something like this.
This is from the EU armory if that makes a difference. 

head=warlords_dreadweave_hood,enchant=30sp_20crit
neck=wrathful_gladiators_pendant_of_subjugation
shoulders=warlords_dreadweave_mantle,enchant=24sp_15crit
chest=warlords_dreadweave_robe
waist=relentless_gladiators_cord_of_alacrity,gems=5sp
...

Reported by impulz79 on 2010-03-25 02:32:50

navv1234 commented 9 years ago 
yep, getting the same issue

Reported by bamtonio on 2010-03-25 03:21:43

navv1234 commented 9 years ago 
Seeing the same issues but reproduced on a mage and a balance druid as well.

Reported by hanson.andrew on 2010-03-25 04:21:04

navv1234 commented 9 years ago 
This is the same issue as #281

It is caused by a changed in data format on the wowhead site.
I've committed a fix for SimulationCraft but Dedmon will need to release a new build
for those that don't compile from source.

Once you do update you should regenerate your profiles.

Reported by delmortis1 on 2010-03-25 06:32:25

navv1234 commented 9 years ago 
If this is caused by a problem on the wowhead site why was I seeing it with Rawr
imported characters as well?

Reported by hanson.andrew on 2010-03-25 11:25:34

navv1234 commented 9 years ago 
Nevermind, I haven't had my coffee yet and see where I'm wrong

Reported by hanson.andrew on 2010-03-25 11:26:51

navv1234 commented 9 years ago 
I'm having the same problem, but both Wowhead & Armory imports are generating bogus
results (e.g., project ~3200 
DPS vs. the usuall 9500+ DPS).  And both the v332.3 and the v333-0 simulators are doing
same thing, so would guess 
its a server side format change.

Reported by agromenix on 2010-03-25 12:12:49

navv1234 commented 9 years ago 
Just uploaded a new release that resolves this issue.

Reported by natehieter on 2010-03-25 13:47:02