search

simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.41k stars 700 forks source link

Gnawed Thumb Ring not reported in fire mage simulations? #2994

Closed nzifnab closed 8 years ago

nzifnab commented 8 years ago

I was trying to compare Gnawed Thumb Ring output vs my Band of Callous Dominance on my fire mage (the ring can be found here: http://www.wowhead.com/item=134526/gnawed-thumb-ring&bonus=1826)

But I'm noticing that under "Buffs" the buff it gives you ("Taste of Mana") is noticeably absent; causing the ring to appear to sim lower than my other ring, even though I suspect that effect would increase my DPS.

I'm using windows 64bit SimC 703-04 (the nightly build from simulationcraft.org)

I suppose for completion's sake, here's the simc profile I'm using:

mage=Zyfnab_Callous_Bloodscent
origin="https://us.api.battle.net/wow/character/darkspear/Zyfnab/advanced"
thumbnail="http://us.battle.net/static-render/us/darkspear/99/123935075-avatar.jpg"
level=110
race=gnome
role=spell
position=back
professions=tailoring=800/jewelcrafting=800
talents=http://us.battle.net/wow/en/tool/talent-calculator#eZ!1011010
artifact=54:0:0:0:0:748:1:749:3:750:3:751:3:752:3:753:1:754:3:755:3:756:3:758:1:759:1:761:1:762:1:763:1:1340:1
spec=fire

# This default action priority list is automatically created based on your character.
# It is a attempt to provide you with a action list that is both simple and practicable,
# while resulting in a meaningful and good simulation. It may not result in the absolutely highest possible dps.
# Feel free to edit, adapt and improve it to your own needs.
# SimulationCraft is always looking for updates and improvements to the default action lists.

# Executed before combat begins. Accepts non-harmful actions only.
actions.precombat=flask,type=flask_of_the_whispered_pact
actions.precombat+=/food,type=the_hungry_magister
actions.precombat+=/augmentation,type=defiled
actions.precombat+=/snapshot_stats
actions.precombat+=/mirror_image
actions.precombat+=/potion,name=deadly_grace
actions.precombat+=/pyroblast

# Executed every time the actor is available.
actions=counterspell,if=target.debuff.casting.react
actions+=/time_warp,if=(time=0&buff.bloodlust.down)|(buff.bloodlust.down&equipped.132410)
actions+=/mirror_image,if=buff.combustion.down
actions+=/rune_of_power,if=cooldown.combustion.remains>40&buff.combustion.down&(cooldown.flame_on.remains<5|cooldown.flame_on.remains>30)&!talent.kindling.enabled|target.time_to_die.remains<11|talent.kindling.enabled&(charges_fractional>1.8|time<40)&cooldown.combustion.remains>40
actions+=/call_action_list,name=combustion_phase,if=cooldown.combustion.remains<=action.rune_of_power.cast_time+(!talent.kindling.enabled*gcd)|buff.combustion.up
actions+=/call_action_list,name=rop_phase,if=buff.rune_of_power.up&buff.combustion.down
actions+=/call_action_list,name=single_target

actions.active_talents=flame_on,if=action.fire_blast.charges=0&(cooldown.combustion.remains>40+(talent.kindling.enabled*25)|target.time_to_die.remains<cooldown.combustion.remains)
actions.active_talents+=/blast_wave,if=(buff.combustion.down)|(buff.combustion.up&action.fire_blast.charges<1&action.phoenixs_flames.charges<1)
actions.active_talents+=/meteor,if=cooldown.combustion.remains>30|(cooldown.combustion.remains>target.time_to_die)|buff.rune_of_power.up
actions.active_talents+=/cinderstorm,if=cooldown.combustion.remains<cast_time&(buff.rune_of_power.up|!talent.rune_on_power.enabled)|cooldown.combustion.remains>10*spell_haste&!buff.combustion.up
actions.active_talents+=/dragons_breath,if=equipped.132863
actions.active_talents+=/living_bomb,if=active_enemies>1&buff.combustion.down

actions.combustion_phase=rune_of_power,if=buff.combustion.down
actions.combustion_phase+=/call_action_list,name=active_talents
actions.combustion_phase+=/combustion
actions.combustion_phase+=/potion,name=deadly_grace
actions.combustion_phase+=/blood_fury
actions.combustion_phase+=/berserking
actions.combustion_phase+=/arcane_torrent
actions.combustion_phase+=/use_item,slot=neck
actions.combustion_phase+=/use_item,slot=trinket2
actions.combustion_phase+=/pyroblast,if=buff.hot_streak.up
actions.combustion_phase+=/fire_blast,if=buff.heating_up.up
actions.combustion_phase+=/phoenixs_flames
actions.combustion_phase+=/scorch,if=buff.combustion.remains>cast_time
actions.combustion_phase+=/scorch,if=target.health.pct<=25&equipped.132454

actions.rop_phase=rune_of_power
actions.rop_phase+=/pyroblast,if=buff.hot_streak.up
actions.rop_phase+=/call_action_list,name=active_talents
actions.rop_phase+=/pyroblast,if=buff.kaelthas_ultimate_ability.react
actions.rop_phase+=/fire_blast,if=!prev_off_gcd.fire_blast
actions.rop_phase+=/phoenixs_flames,if=!prev_gcd.phoenixs_flames
actions.rop_phase+=/scorch,if=target.health.pct<=25&equipped.132454
actions.rop_phase+=/fireball

actions.single_target=pyroblast,if=buff.hot_streak.up&buff.hot_streak.remains<action.fireball.execute_time
actions.single_target+=/phoenixs_flames,if=charges_fractional>2.7&active_enemies>2
actions.single_target+=/flamestrike,if=talent.flame_patch.enabled&active_enemies>2&buff.hot_streak.react
actions.single_target+=/pyroblast,if=buff.hot_streak.up&!prev_gcd.pyroblast
actions.single_target+=/pyroblast,if=buff.hot_streak.react&target.health.pct<=25&equipped.132454
actions.single_target+=/pyroblast,if=buff.kaelthas_ultimate_ability.react
actions.single_target+=/call_action_list,name=active_talents
actions.single_target+=/fire_blast,if=!talent.kindling.enabled&buff.heating_up.up&(!talent.rune_of_power.enabled|charges_fractional>1.4|cooldown.combustion.remains<40)&(3-charges_fractional)*(12*spell_haste)<cooldown.combustion.remains+3|target.time_to_die.remains<4
actions.single_target+=/fire_blast,if=talent.kindling.enabled&buff.heating_up.up&(!talent.rune_of_power.enabled|charges_fractional>1.5|cooldown.combustion.remains<40)&(3-charges_fractional)*(18*spell_haste)<cooldown.combustion.remains+3|target.time_to_die.remains<4
actions.single_target+=/phoenixs_flames,if=(buff.combustion.up|buff.rune_of_power.up|buff.incanters_flow.stack>3|talent.mirror_image.enabled)&artifact.phoenix_reborn.enabled&(4-charges_fractional)*13<cooldown.combustion.remains+5|target.time_to_die.remains<10
actions.single_target+=/phoenixs_flames,if=(buff.combustion.up|buff.rune_of_power.up)&(4-charges_fractional)*30<cooldown.combustion.remains+5
actions.single_target+=/scorch,if=target.health.pct<=25&equipped.132454
actions.single_target+=/fireball

head=darcklis_dragonfire_diadem,id=132863,bonus_id=1811
neck=sorcerous_shadowruby_pendant,id=130233,bonus_id=1749/689/600/669,gems=150crit,enchant=mark_of_the_hidden_satyr
shoulders=amice_of_cruel_laughter,id=137503,bonus_id=3413/1808/1507/3336,gems=150crit
back=drape_of_vile_misfortune,id=137530,bonus_id=3416/1808/1512/1813,gems=150crit,enchant=200int
chest=maddening_robe_of_secrets,id=139193,bonus_id=1805/1487
wrists=harrowing_soulspun_bracers,id=134437,bonus_id=3412/1517/3337
hands=silken_bloodscent_gloves,id=133609,bonus_id=3415/1517/3336
waist=netherwhisper_cinch,id=134391,bonus_id=3416/1542/3337
legs=netherwhisper_leggings,id=134394,bonus_id=3414/1532/3337
feet=treads_of_light,id=139280,bonus_id=3417/1527/3337
finger1=sephuzs_secret,id=132452,bonus_id=1811,gems=200int,enchant=200crit
finger2=band_of_callous_dominance,id=134528,bonus_id=3417/1808/40/1512/1813,gems=150crit,enchant=200crit
trinket1=naraxas_spiked_tongue,id=137349,bonus_id=3413/1808/1507/3336,gems=150crit
trinket2=wriggling_sinew,id=139326,bonus_id=1805/1487
main_hand=felomelorn,id=128820,bonus_id=730,gem_id=133686/137379/139256/0,relic_id=3418:1532:3337/3415:1512:3336/1805:1487/0
off_hand=heart_of_the_phoenix,id=133959

# Gear Summary
# gear_ilvl=871.69
# gear_stamina=23899
# gear_intellect=24558
# gear_crit_rating=12087
# gear_haste_rating=3622
# gear_mastery_rating=3452
# gear_versatility_rating=1449
# gear_avoidance_rating=326
# gear_armor=1751

copy=Zyfnab_Gnawed_Thumb_Bloodscent,Zyfnab_Callous_Bloodscent
finger2=gnawed_thumb_ring,id=134526,bonus_id=3417/1808/1512/1813,gems=150crit,enchant=200crit

copy=Zyfnab_Gnawed_Thumb_Bonespeaker,Zyfnab_Gnawed_Thumb_Bloodscent
hands=,id=134217,bonus_id=3416/1527/3336

copy=Zyfnab_Callous_Bonespeaker,Zyfnab_Callous_Bloodscent
hands=,id=134217,bonus_id=3416/1527/3336
Frostedmages commented 8 years ago

You are not using a use_item line for the ring. Add default_actions=1 to your primary profile when using the copy command.

nzifnab commented 8 years ago

@Frostedmages I did an import for the character; Does the import only put that line into this default action list if you're wearing the ring? I'd assume this list is the default actions, so I'm unclear how specifically telling the copies to have default_actions=1 would affect the results. Though I will try it.

Frostedmages commented 8 years ago

When you import a character, it generates an APL for that character from the master in the mage module. Your original profile didn't have the ring, so it didn't bother giving you a use_item line for it. default_actions=1 will tell the sim to re-build the APL, and having that in your copy= profiles will ensure it is rebuilt when the ring is there, so it'll add the ring action.