search

simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.4k stars 693 forks source link

Shadowmourne, Fangs of the Father, Tarecgosa, Warglaives are not working. #4372

Closed JBA9084 closed 4 years ago

JBA9084 commented 6 years ago

Overview: Old legendaries do not work(excluding cloak). Shadowmourne does not generate soul fragments or trigger chaos bane, Tarecgosa does not trigger Wrath of Tarecgosa, Fangs do not generate agility stacks or CP buff, and Warglaives do not give Attack Power vs Demons or trigger their haste buff.

Note: I know the fangs say their set bonus is disabled, but they were hotfixed to work in Timewalking dungeons in 6.2.3; https://worldofwarcraft.com/en-us/news/19962858

Simulationcraft Version

801-01

If Simulationcraft is crashing, please include your dxdiag file - Instructions here -

No crash

Reproduction Steps:

Place the following lines beneath your character information at the top of your Simulate tab:

timewalk=70 scale_to_itemlevel=95

The itemlvl part does not matter, just the sim bugs if you do not include it. After you place those lines, replace your weapon with one of the legendaries above in your base profile or a copy, then sim.

Once you check your sim results, you will see the legendary procs are completely absent.

navv1234 commented 6 years ago

Old legendaries are no longer implemented in the simulator. Nobody is currently interested in implementing them either.

JBA9084 commented 6 years ago

Ah I see, thank you. Is there any specific literature I can read to try myself? I'd love to learn.

N1gh7h4wk commented 6 years ago

The wiki points to how to build it yourself, then you'd prolly want to make them work similar to other items in unique_gear_x.cpp

JBA9084 commented 6 years ago

Thank you very much for pointing me in this direction, I'm currently installing QT and downloading Microsoft Visual Studio Express 2013. One last thing, will I be able to find the proc rates and other info required for making the items in unique_gear_x.cpp, or is it somewhere else?

scamille commented 6 years ago

Uuuh please get Visual Studio Community 2017. We don't even support 2013 anymore, and that guide was just horribly outdated. I updated it somewhat.

N1gh7h4wk commented 6 years ago

hmm the procc rates should be in the spell data itself, at least if its whitelisted to be pulled into that. unique item effects are implemented in the respective unique gear files like for example legion had karazahn stuff https://github.com/simulationcraft/simc/blob/f9ac2bd24b929f23fe07cda8a161b23ea198ab03/engine/player/sc_unique_gear_x6.cpp#L483

scamille commented 4 years ago

Closing this. If you ever find the time to add support for this item, feel free to open a pull request.