simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.42k stars 704 forks source link

using wrong crit chance #4590

Closed Romalla closed 6 years ago

Romalla commented 6 years ago

sims are using melee crit chance for my fire mage (havent tested any others) blizz ui has my crit at 1026, annd the armory import profile shows it at 933 which raid bots shows as my melee crit chance.

I expected to have more crit than haste allowing reorigination array to provide crit, but my crit shows slightly less then what the blizz ui says and it is now giving me haste as my RA buff

i can provide a screen shot of blizz ui and of simc import if you need it

latest nightly build as of oct 27th 2018

SimulationCraft 801-02 for World of Warcraft 8.0.1 Live (wow build 27980)

Using QT 5.10.1 with WebEngine

Begin GUI options

ptr=0 item_db_source=ptrhead/local/bcpapi/wowhead target_error=0 iterations=100000 default_world_lag=0.05 max_time=300 vary_combat_length=0.2 tmi_window_global=6 target_level+=3 target_race=Humanoid optimal_raid=0 override.bloodlust=1 override.arcane_intellect=1 override.power_word_fortitude=1 override.battle_shout=1 override.bleeding=1 override.mortal_wounds=1 override.chaos_brand=1 override.mystic_touch=1 threads=10 process_priority=High statistics_level=1

End GUI options

Begin simulateText

mage="Romalla" source=blizzard origin="https://us.battle.net/wow/character/illidan/romalla/advanced" thumbnail="https://render-us.worldofwarcraft.com/character/illidan/200/132945352-avatar.jpg" spec=fire level=120 race=troll role=spell position=back professions=tailoring=141/enchanting=150 talents=https://worldofwarcraft.com/en-us/game/talent-calculator#mage/fire/talents=3231123

vituscze commented 6 years ago

The spells are most definitely using spell crit chance. There was an issue with Reorigination Array not granting the right buff which should be fixed now.