search

simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.42k stars 700 forks source link

Wierd Inconsistency on Festering Strike of Unholy DK #5695

Closed hyqwow9 closed 3 years ago

hyqwow9 commented 3 years ago

Hi Simc staff:

Describe the bug

I find there is a significant inconsistency on Festering Strike of Unholy DK. The average damage of Festering Strike is 1440 as I attack the raid dummy at Bastion, while the corresponding average damage in simc is 1800. I have modified the profile and have deleted all buffs, foods, potion, etc... as shown in the attachment. There is a 20% difference on the damage, and it seems to be very wierd.

Expected behavior

Damage on Festering Strike should be consistent with in-game damage.

To Reproduce

Simply casting Festering Strike at raid dummy and then using simc to simulate the exact same profile will show the difference on the average damage.

Additional information

simc.gui: simc_gui.zip

Simc Result: Simc Result

Festering Strike damage in game: Average damage 1440, acquired from skada. From top to buttom are min, max and average damage. Festering Strike

Auto attack damage in game: Auto attack

Simc buffs: No food, potion, flask, bloodthirst, etc...... Simc Buffs

Where I test damage in game: Raid Dummy

hyqwow9 commented 3 years ago

Festering Strike deals physical damage, which means mastery will not affect it. Reasonably Fstering Strike should be independent to all other skills, or at least nearly independent. That's why I find it so wierd.

Melekus commented 3 years ago

Thanks for the issue, it looks like Festering Strike rank 2 ingame doesn't actually increase Festering Strike damage by 20% like its tooltip implies, but instead increases Festering Wound damage by the same amount.

hyqwow9 commented 3 years ago

That's probably it. Thank you so much for fix the issue! Meanwhile I still have 150-200 dps gap comparing to simc result lol.

Melekus commented 3 years ago

If you have observed other damage differences between simc and the game, feel free to report it. Just know that you shouldn't be basing everything on the "average" metrics, because an average may and will vary a lot for your limited sample size. Your usage during testing may also vary a lot from how a default simulation is run, with regards to buff uptime and cooldown usage that will affect the average damage.

The best way is to compare the minimum damage observed in simc vs ingame, or you can tweak the simc profile so it doesn't use cooldowns and compare ingame damage to that if you know how to do it.