simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.39k stars 693 forks source link

Balance druid unable to cast starsurge outside of moonkin form #6134

Closed slaymaker1907 closed 3 years ago

slaymaker1907 commented 3 years ago

Describe the bug

While moonkin form is required to cast starsurge for balance affinity, true balance druids can cast starsurge without being in moonkin form.

Expected behavior

The following basic balance druid APL should still cast starsurge despite not ever being in moonkin form.

To Reproduce

Here is a small APL which does not activate moonkin form and thus never ends up casting starsurge.

actions=moonfire,if=!ticking
actions+=/sunfire,if=!ticking
actions+=/stellar_flare,if=!ticking
actions+=/starsurge,if=eclipse.in_solar|(buff.eclipse_lunar.remains<3&eclipse.in_lunar&astral_power>70)
actions+=/starfire,if=eclipse.solar_next|eclipse.any_next|eclipse.in_lunar
actions+=/wrath

For reference, here is druid's character info minus name/realm.

# SimC Addon 9.1.0-01
# Requires SimulationCraft 910-01 or newer

druid="Example"
level=60
race=night_elf
region=universe
server=wow
role=spell
professions=mining=150/engineering=1
talents=1332111
spec=balance

covenant=venthyr
soulbind=theotar_the_mad_duke:9,336239/271:8:0/336140/280:6:0/336184/283:8:0/259:6:0/319983/262:8:0/351748/256:7:0/351750
renown=60

head=,id=178691,bonus_id=7591/7359/41/7574/1560/6646
neck=,id=173145,gem_id=173130,bonus_id=7461,drop_level=60,crafted_stats=36
shoulder=,id=186298,gem_id=187063,bonus_id=7188/6652/1485/6646
back=,id=180123,enchant_id=6204,bonus_id=7615/7359/6652/1543/6646
chest=,id=178698,enchant_id=6230,bonus_id=7354/7359/6652/1540/6646
wrist=,id=186297,bonus_id=7188/6652/7575/1485/6646
hands=,id=178832,bonus_id=7600/7359/42/1540/6646
waist=,id=172320,gem_id=173130,bonus_id=7474/6649/6648/6935/7450/1546
legs=,id=178801,bonus_id=7586/7359/6652/1543/6646
feet=,id=186299,gem_id=187308,bonus_id=7189/6652/1472/6646
finger1=,id=178871,enchant_id=6168,gem_id=173130,bonus_id=7620/7359/6652/7576/1560/6646
finger2=,id=178824,enchant_id=6168,bonus_id=7359/6652/7575/7618/1553/6646
trinket1=,id=179350,bonus_id=7359/6652/7604/1553/6646
trinket2=,id=178772,bonus_id=7601/7359/42/1543/6646
main_hand=,id=178714,enchant_id=6229,bonus_id=7648/7359/6652/1560/6646

Additional information

Here is the raw simc input:

# Base Actor
# SimC Addon 9.1.0-01
# Requires SimulationCraft 910-01 or newer

druid="Example"
level="60"
race="night_elf"
region="universe"
server="wow"
role="spell"
professions="mining=150/engineering=1"
talents="1332111"
spec="balance"

covenant="venthyr"
soulbind="theotar_the_mad_duke:9,336239/271:8:0/336140/280:6:0/336184/283:8:0/259:6:0/319983/262:8:0/351748/256:7:0/351750"
renown="60"

head=",id=178691,bonus_id=7591/7359/41/7574/1560/6646"
neck=",id=173145,gem_id=173130,bonus_id=7461,drop_level=60,crafted_stats=36"
shoulder=",id=186298,gem_id=187063,bonus_id=7188/6652/1485/6646"
back=",id=180123,enchant_id=6204,bonus_id=7615/7359/6652/1543/6646"
chest=",id=178698,enchant_id=6230,bonus_id=7354/7359/6652/1540/6646"
wrist=",id=186297,bonus_id=7188/6652/7575/1485/6646"
hands=",id=178832,bonus_id=7600/7359/42/1540/6646"
waist=",id=172320,gem_id=173130,bonus_id=7474/6649/6648/6935/7450/1546"
legs=",id=178801,bonus_id=7586/7359/6652/1543/6646"
feet=",id=186299,gem_id=187308,bonus_id=7189/6652/1472/6646"
finger1=",id=178871,enchant_id=6168,gem_id=173130,bonus_id=7620/7359/6652/7576/1560/6646"
finger2=",id=178824,enchant_id=6168,bonus_id=7359/6652/7575/7618/1553/6646"
trinket1=",id=179350,bonus_id=7359/6652/7604/1553/6646"
trinket2=",id=178772,bonus_id=7601/7359/42/1543/6646"
main_hand=",id=178714,enchant_id=6229,bonus_id=7648/7359/6652/1560/6646"
name="Example"

# Consumables
potion="disabled"
food="disabled"
flask="disabled"
augmentation="disabled"

# Expansion Options
shadowlands.soleahs_secret_technique_type="haste"
shadowlands.enable_rune_words="1"
temporary_enchant="main_hand:shadowcore_oil"
shadowlands.stone_legionnaires_in_party="0"
shadowlands.crimson_choir_in_party="0"
shadowlands.disable_iqd_execute="0"
shadowlands.iqd_stat_fail_chance="0.1"
shadowlands.unbound_changeling_stat_type=""
# Custom APL

actions="/moonfire,if=!ticking"
actions+="/sunfire,if=!ticking"
actions+="/stellar_flare,if=!ticking"
actions+="/starsurge,if=eclipse.in_solar|(buff.eclipse_lunar.remains<3&eclipse.in_lunar&astral_power>70)"
actions+="/starfire,if=eclipse.solar_next|eclipse.any_next|eclipse.in_lunar"
actions+="/wrath"

# Actors

# Simulation Options
iterations="5000"
desired_targets="1"
max_time="300"
calculate_scale_factors="0"
scale_only="strength,intellect,agility,crit,mastery,vers,haste,weapon_dps,weapon_offhand_dps"
override.bloodlust="0"
override.arcane_intellect="0"
override.power_word_fortitude="0"
override.battle_shout="0"
override.mystic_touch="0"
override.chaos_brand="0"
override.windfury_totem="0"
override.bleeding="0"
report_details="1"
single_actor_batch="1"
optimize_expressions="1"
gastank commented 3 years ago

fixed in 36bf15b