simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.4k stars 694 forks source link

Enable macos nightly build with Qt6.5 #7543

Closed scamille closed 2 months ago

scamille commented 1 year ago

I recently tried publishing our nightly builds with the newly released Qt6.5 and hit a blocker with the macos build, see https://github.com/simulationcraft/simc-publish/pull/20

There are errors on macos with std::filesystem::path, see https://github.com/simulationcraft/simc-publish/actions/runs/4636357824/jobs/8204171694

/Users/runner/work/simc-publish/Qt/6.5.0/macos/lib/QtCore.framework/Headers/qfileinfo.h:99:22: error: 'path' is unavailable: introduced in macOS 10.15
    std::filesystem::path filesystemPath() const { return QtPrivate::toFilesystemPath(path()); }
                     ^
/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/c++/v1/filesystem:909:24: note: 'path' has been explicitly marked unavailable here
class _LIBCPP_TYPE_VIS path {
                       ^
In file included from ../qt/ImportTab.cpp:7:
In file included from ../qt/sc_AddonImportTab.hpp:8:
In file included from ../qt/util/sc_textedit.hpp:10:
In file included from /Users/runner/work/simc-publish/Qt/6.5.0/macos/lib/QtGui.framework/Headers/QtGui:3:
In file included from /Users/runner/work/simc-publish/Qt/6.5.0/macos/lib/QtGui.framework/Headers/QtGuiDepends:3:
In file included from /Users/runner/work/simc-publish/Qt/6.5.0/macos/lib/QtCore.framework/Headers/QtCore:80:
In file included from ../../Qt/6.5.0/macos/lib/QtCore.framework/Headers/qdir.h:9:
/Users/runner/work/simc-publish/Qt/6.5.0/macos/lib/QtCore.framework/Headers/qfileinfo.h:100:22: error: 'path' is unavailable: introduced in macOS 10.15
    std::filesystem::path filesystemAbsolutePath() const
                     ^

If anyone is interested and willing to fix this, please create a pull request for it. I assume that either adjusting some setting (macOS>= 10.15) or adjusting the libc++ version used might fix it, but I personally have no clue about how macos works :-)

fyi @navv1234 @wfarr @philipp-spiess @nuoHep

seanpeters86 commented 5 months ago

@scamille is this still relevant?

navv1234 commented 2 months ago

Macos Nightlies are built with Qt 6.5, so no. Closing as completed.