simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.41k stars 697 forks source link

[Hunter] Flaming Arrow removing pre_improved_steady_shot #845

Closed navv1234 closed 9 years ago

navv1234 commented 9 years ago

Originally reported on Google Code with ID 846

It seems that the t12_2pc proc, Flaming Arrow, is causing pre_improved_steady_shot to
be removed, breaking the Improved Steady shot behavior. Here is a section of log showing
this behavior (action list used to generate the log consisted only of steady shot,
no other abilities):

382.30   Actor Fluffy_Pillow has 1 scheduled events

382.36   Executing event: Action Travel
382.36   Player Fluffy_Pillow loses 0.00 (5889.49) health
382.36   Cybeloras steady_shot hits Fluffy_Pillow for 5889 physical damage (hit)
382.36   Cybeloras performs flaming_arrow (100)
382.36   action_t::player_buff: flaming_arrow hit=0.00 crit=0.00 penetration=0 spell_power=0.00
attack_power=15575.05 
382.36   attack_t::player_buff: flaming_arrow hit=0.08 expertise=0.00 crit=0.37
382.36   action_t::target_debuff: flaming_arrow multiplier=1.08 hit=0.00 crit=0.00
attack_power=1772.00 spell_power=0.00 penetration=0
382.36   attack_t::build_table: flaming_arrow miss=-0.000 dodge=0.000 parry=0.000 glance=0.000
block=0.000 crit_block=0.000 crit=0.000
382.36   Cybeloras result for flaming_arrow is crit
382.36   action_t::cost: flaming_arrow 0.00 0.00 mana
382.36   Cybeloras consumes 0.0 mana for flaming_arrow (120)
382.36   Cybeloras weapon damage for flaming_arrow: td=7175.664 wd=2678.000 bd=0.000
ws=3.300 pd=4497.664 ap=19081.000
382.36   Cybeloras crit_bonus for flaming_arrow: cb=1.000 b_cb=1.00 b_cm=1.00 b_cbm=1.00
382.36   Cybeloras queries resistance for flaming_arrow: 0.00
382.36   Cybeloras dmg for flaming_arrow: dd=12772 i_dd=6386 w_dd=5741 b_dd=0 mod=0.00
power=19081 b_mult=1.00 p_mult=1.03 t_mult=1.08 w_mult=0.80
382.36   Player Fluffy_Pillow loses 0.00 (12771.53) health
382.36   Cybeloras flaming_arrow hits Fluffy_Pillow for 12772 fire damage (crit)
382.36   Cybeloras loses pre_improved_steady_shot

382.40   Executing event: Player-Ready

Reported by ascott18 on 2011-08-30 07:16:05

navv1234 commented 9 years ago
Just to be sure, here is the profile used:

#!./simc 

hunter=Cybeloras
origin="http://us.battle.net/wow/en/character/malganis/cybeloras/advanced"
level=85
race=orc
role=attack
use_pre_potion=1
professions=engineering=525/enchanting=525
talents=http://www.wowhead.com/talent#hunter-0320020000000000000230232003212023122103000000000000000000
glyphs=rapid_fire/steady_shot/aimed_shot/raptor_strike/ice_trap/disengage/aspect_of_the_pack/feign_death/lesser_proportion
actions=flask,type=winds
actions+=/steady_shot
head=scalp_of_the_bandit_prince,heroic=1,type=mail,ilevel=391,quality=epic,stats=2214armor_400agi_689sta_310crit_234mastery,reforge=mastery_haste,gems=agile_shadowspirit_20agi_20crit_30haste,enchant=60agi_35haste
neck=choker_of_the_vanquished_lord,ilevel=384,quality=epic,stats=240agi_360sta_162haste_156mastery,reforge=mastery_hit
shoulders=flamewakers_spaulders,type=mail,ilevel=378,quality=epic,stats=1952armor_282agi_454sta_208mastery_170haste,reforge=mastery_hit,gems=40agi_10mastery,enchant=50agi_25mastery
shirt=amber_filigreed_doublet,ilevel=1
chest=flamewakers_tunic,type=mail,ilevel=378,quality=epic,stats=2603armor_368agi_611sta_243mastery_255crit,reforge=mastery_hit,gems=40agi_20agi_20haste_20agi,enchant=20all
waist=firearrow_belt,type=mail,ilevel=378,quality=epic,stats=1464armor_282agi_454sta_182mastery_193haste,reforge=mastery_crit,gems=40agi_40agi
legs=flamewakers_legguards,type=mail,ilevel=378,quality=epic,stats=2278armor_368agi_611sta_278hit_211haste,reforge=hit_crit,gems=40agi_20agi_20hit_20agi,enchant=190ap_55crit
feet=decimation_treads,type=mail,ilevel=378,quality=epic,stats=1790armor_281agi_454sta_176hit_199crit,reforge=hit_haste,gems=40agi_10agi,enchant=25agi
wrists=hidebound_chains,type=mail,ilevel=378,quality=epic,stats=1139armor_227agi_341sta_173haste_115hit,reforge=haste_crit,enchant=50agi
hands=flamewakers_gloves,heroic=1,type=mail,ilevel=391,quality=epic,stats=1703armor_322agi_513sta_231crit_202haste,gems=20agi_20haste_10agi,enchant=50haste,addon=synapse_springs
finger1=viridian_signet_of_the_avengers,ilevel=391,quality=epic,stats=236agi_384sta_181haste_134mastery,reforge=mastery_hit,gems=40agi_10agi,enchant=40agi
finger2=widows_kiss,ilevel=378,quality=epic,stats=227agi_341sta_167haste_126mastery,reforge=mastery_crit,enchant=40agi
trinket1=the_hungerer,heroic=1,ilevel=391,quality=epic,stats=433agi,equip=onattackhit_1730haste_100%_15dur_60cd
trinket2=matrix_restabilizer,ilevel=384,quality=epic,stats=406agi
back=dreadfire_drape,heroic=1,ilevel=391,quality=epic,stats=745armor_241agi_384sta_113mastery_158hit,reforge=mastery_crit,gems=40agi_40agi_20agi,enchant=65crit
main_hand=ranseur_of_hatred,ilevel=378,quality=epic,stats=408agi_611sta_284crit_252haste,reforge=haste_hit,enchant=130agi,weapon=polearm_3.60speed_2142min_3214max
ranged=ruthless_gladiators_longbow,ilevel=391,quality=epic,stats=145agi_217sta_96crit_96resil,enchant=flintlockes_woodchucker,weapon=bow_3.00speed_2015min_3024max

pet=wind_serpent,EIGHTPERCENT_12060310
talents=000000000000000000000000000000000000000002010000023300002110020
active=owner
summon_pet=EIGHTPERCENT_12060310

Reported by ascott18 on 2011-08-30 07:27:01

navv1234 commented 9 years ago
Discrepancies can be easily found by doing a ctrl+f for pre_improved_steady_shot in
the gory detail log of the sim. Here are 2 of them:

    Line 67378: 70.41    Cybeloras gains pre_improved_steady_shot(1) ( value=0.00 )
    Line 67474: 71.41    Cybeloras loses pre_improved_steady_shot
    Line 67520: 71.66    Cybeloras gains pre_improved_steady_shot(1) ( value=0.00 )
    Line 67636: 72.89    Cybeloras gains pre_improved_steady_shot(2) ( value=0.00 )
    Line 67638: 72.89    Cybeloras loses pre_improved_steady_shot
    Line 67762: 74.12    Cybeloras gains pre_improved_steady_shot(1) ( value=0.00 )
    Line 67887: 75.35    Cybeloras gains pre_improved_steady_shot(2) ( value=0.00 )
    Line 67889: 75.35    Cybeloras loses pre_improved_steady_shot
    Line 68009: 76.57    Cybeloras gains pre_improved_steady_shot(1) ( value=0.00 )
    Line 68108: 77.57    Cybeloras loses pre_improved_steady_shot
    Line 68151: 77.81    Cybeloras gains pre_improved_steady_shot(1) ( value=0.00 )
    Line 68281: 79.06    Cybeloras gains pre_improved_steady_shot(2) ( value=0.00 )

These discrepancies do not occur after removing 3 pieces of t12 from the profile and
re-running the simulation.

Reported by ascott18 on 2011-08-30 07:32:31

navv1234 commented 9 years ago
Fixed in r4296

Reported by swbusche on 2011-08-30 12:59:02