GUI crash

[navv1234]

Originally reported on Google Code with ID 859

What steps will reproduce the problem?
1. Import my warrior (either chardev http://chardev.org/?profile=225273 or battle.net
http://us.battle.net/wow/en/character/blackrock/Kokekola/simple )
2. Use default options.
3. Hit simulate

What is the expected output? What do you see instead?
It crashes.

What version of the product are you using? On what operating system?
Win7 x64 ultimate, r9584

Please provide any additional information below.
Clicking the problem details shows this.

roblem signature:
  Problem Event Name:   BEX
  Application Name: SimulationCraft.exe
  Application Version:  0.0.0.0
  Application Timestamp:    4e6f017f
  Fault Module Name:    MSVCR90.dll
  Fault Module Version: 9.0.30729.6161
  Fault Module Timestamp:   4dace5b9
  Exception Offset: 0006ccd5
  Exception Code:   c0000417
  Exception Data:   00000000
  OS Version:   6.1.7601.2.1.0.256.1
  Locale ID:    1033
  Additional Information 1: cfb3
  Additional Information 2: cfb3e4c44dd39008b4d38f72cf7b16f1
  Additional Information 3: 5fc5
  Additional Information 4: 5fc5f24f8a43ea514bcceb66853e1859

Read our privacy statement online:
  http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0409

If the online privacy statement is not available, please read our privacy statement
offline:
  C:\Windows\system32\en-US\erofflps.txt

Reported by arexdramon on 2011-09-13 07:22:11

[navv1234]

Crash for me too.

I get this window=
http://dl.dropbox.com/u/35158399/Presse-papiers-1.png

(Sorry the message is in French)
Hope this help.

Reported by blubibulga on 2011-09-14 09:25:50

[navv1234]

I'm not crashing importing your profile with the latest HEAD, can you update and see
if you still crash?

Reported by swbusche on 2011-09-16 14:33:06

[navv1234]

Simcraft is crashing for me as well, completely closes the sim out with no explaination.
Running win 7 64bit. 

Reported by drtrugger on 2011-09-16 18:06:20

[navv1234]

Drtrug - we have no way to reproduce your crash if you don't give us more information.
Please include the simc_gui.simc file or the file you're feeding the CLI.

Thanks.

Reported by swbusche on 2011-09-16 18:19:21

[navv1234]

Bahhhhh. I'd try to run sims again, preferably with the latest build, but now I'm getting
an error in Visual C++ 2008 when opening simcqt.vcproj (r9615). QT dlls were copied
prior to opening the vcproj file too. I haven't change anything concerning VC++ 2008
(I -only- compile simulationcraft with it)

The following error has occurred during XML parsing:

File: D:\simcraft_SVN_BUILDHERE\simcqt.vcproj
Line: 504
Column: 11
Error Message:
The name in the end tag of the element must match the element type in the start tag.

The file 'D:\simcraft_SVN_BUILDHERE\simcqt.vcproj' has failed to load.

Reported by arexdramon on 2011-09-17 09:12:41

[navv1234]

I found the problem. Whoever added the sc_dot.cpp in that vcproj file didnt close it
with a </file>

Reported by arexdramon on 2011-09-17 09:16:45

[navv1234]

Thanks, I've fixed the build error.

Reported by swbusche on 2011-09-17 15:02:19

[navv1234]

I'm not sure if this is a related issue or not, but I am experiencing build crashes
as well for some odd reason; no matter the profile used. Picking any random BIS profile
will crash the program.

Reported by trigunflame on 2011-09-17 19:42:59

---

• Attachment: 1.png
  
• Attachment: SimCraftCrashDump.zip

[navv1234]

Message when running in release:

Problem signature:
  Problem Event Name:   BEX
  Application Name: SimulationCraft.exe
  Application Version:  0.0.0.0
  Application Timestamp:    4e74f889
  Fault Module Name:    MSVCR90.dll
  Fault Module Version: 9.0.30729.6161
  Fault Module Timestamp:   4dace5b9
  Exception Offset: 0006ccd5
  Exception Code:   c0000417
  Exception Data:   00000000
  OS Version:   6.1.7601.2.1.0.256.1
  Locale ID:    1033
  Additional Information 1: b679
  Additional Information 2: b67968ce8828163893e32d5ee87a5362
  Additional Information 3: 9dfc
  Additional Information 4: 9dfc9f2c10488735222f8364a51487dd

Reported by trigunflame on 2011-09-17 19:46:09

[navv1234]

Ok, successfully compiled r9616, imported my char from battle.net (kokekola from blackrock),
default options, hitting simulate still crashes GUI.

Problem signature:
  Problem Event Name:   BEX
  Application Name: SimulationCraft.exe
  Application Version:  0.0.0.0
  Application Timestamp:    4e751300
  Fault Module Name:    MSVCR90.dll
  Fault Module Version: 9.0.30729.6161
  Fault Module Timestamp:   4dace5b9
  Exception Offset: 0006ccd5
  Exception Code:   c0000417
  Exception Data:   00000000
  OS Version:   6.1.7601.2.1.0.256.1
  Locale ID:    1033
  Additional Information 1: cfb3
  Additional Information 2: cfb3e4c44dd39008b4d38f72cf7b16f1
  Additional Information 3: 7a84
  Additional Information 4: 7a8412154ce1c00c7ccbf9d81e12c79b

Read our privacy statement online:
  http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0409

If the online privacy statement is not available, please read our privacy statement
offline:
  C:\Windows\system32\en-US\erofflps.txt

I saw in a previous post that you wanted a simc_gui.simc file so here is what's in
it.

ptr=0
item_db_source=local/bcpapi/wowhead/mmoc/armory/ptrhead
iterations=1000
default_world_lag=0.1
max_time=450
vary_combat_length=0.2
fight_style=Patchwerk
target_level=88
target_race=humanoid
default_skill=1.0
threads=1
optimal_raid=0
override.dark_intent=0
override.focus_magic=1
override.strength_of_earth=1
override.blessing_of_might=1
override.bloodlust=1
override.communion=1
override.arcane_brilliance=1
override.leader_of_the_pack=1
override.mana_spring_totem=1
override.windfury_totem=1
override.replenishment=1
override.wrath_of_air=1
override.demonic_pact=1
override.fortitude=1
override.blessing_of_kings=1
override.sunder_armor=1
override.thunder_clap=1
override.mangle=1
override.bleeding=1
override.blood_frenzy_physical=1
override.poisoned=1
override.hunters_mark=1
override.critical_mass=1
override.earth_and_moon=1
scale_only=none
dps_plot_stat=none
reforge_plot_stat=none
reforge_plot_output_file=reforge_plot.csv
#!./simc 

warrior=Kokekola
origin="http://us.battle.net/wow/en/character/blackrock/Kokekola/advanced"
level=85
race=undead
position=back
role=attack
use_pre_potion=1
professions=jewelcrafting=525/blacksmithing=525
talents=http://www.wowhead.com/talent#warrior-3022030312021231221103220000000000000000030000000000000000000
glyphs=mortal_strike/overpower/slam/rapid_charge/long_charge/sweeping_strikes/battle/demoralizing_shout/berserker_rage
actions=flask,type=titanic_strength
actions+=/food,type=beer_basted_crocolisk
actions+=/snapshot_stats
actions+=/golemblood_potion,if=!in_combat|buff.recklessness.up|target.time_to_die<26
actions+=/auto_attack
actions+=/stance,choose=berserker,if=(buff.taste_for_blood.down&rage<75)
actions+=/stance,choose=battle,if=(dot.rend.remains=0|((buff.overpower.up|buff.taste_for_blood.up)&cooldown.mortal_strike.remains>1)&rage<=75)
actions+=/recklessness,if=((target.health_pct>20&target.time_to_die>320)|target.health_pct<=20)
actions+=/berserker_rage,if=!buff.deadly_calm.up&rage<70
actions+=/deadly_calm,if=rage<30
actions+=/sweeping_strikes,if=target.adds>0
actions+=/bladestorm,if=target.adds>0&!buff.deadly_calm.up&!buff.sweeping_strikes.up
actions+=/cleave,if=target.adds>0
actions+=/inner_rage,if=!buff.deadly_calm.up&rage>80&cooldown.deadly_calm.remains>15
actions+=/heroic_strike,if=((rage>=85&target.health_pct>=20)|buff.deadly_calm.up|buff.battle_trance.up|((buff.incite.up|buff.colossus_smash.up)&((rage>=50&target.health_pct>=20)|(rage>=75&target.health_pct<20))))
actions+=/overpower,if=buff.taste_for_blood.remains<=1.5
actions+=/mortal_strike,if=target.health_pct>20|rage>=30
actions+=/execute,if=buff.battle_trance.up
actions+=/rend,if=!ticking
actions+=/colossus_smash,if=!buff.colossus_smash.up
actions+=/execute,if=(buff.deadly_calm.up|buff.recklessness.up)
actions+=/mortal_strike
actions+=/overpower
actions+=/execute
actions+=/colossus_smash,if=buff.colossus_smash.remains<=1.5
actions+=/slam,if=(cooldown.mortal_strike.remains>=1.5&(rage>=35|buff.deadly_calm.up|buff.colossus_smash.up))|(cooldown.mortal_strike.remains>=1.2&buff.colossus_smash.remains>0.5&rage>=35)
actions+=/battle_shout,if=rage<20
head=helmet_of_the_molten_giant,type=plate,ilevel=378,quality=epic,stats=2943armor_348str_611sta_245haste_233mastery,reforge=haste_crit,gems=reverberating_shadowspirit_40str_30str,enchant=60str_35mastery
neck=necklace_of_fetishes,heroic=1,ilevel=391,quality=epic,stats=256str_384sta_188crit_142hit,reforge=hit_exp
shoulders=pauldrons_of_the_molten_giant,heroic=1,type=plate,ilevel=391,quality=epic,stats=2822armor_322str_513sta_223crit_210haste,reforge=haste_mastery,gems=40str,enchant=50str_25crit
chest=battleplate_of_the_molten_giant,heroic=1,type=plate,ilevel=391,quality=epic,stats=3762armor_420str_689sta_297crit_263hit,gems=20str_20crit_20str_20crit_20str,enchant=20all
waist=cinch_of_the_flaming_ember,type=plate,ilevel=378,quality=epic,stats=2037armor_282str_454sta_133hit_230crit,gems=20str_20hit_67str_10str
legs=legplates_of_the_molten_giant,heroic=1,type=plate,ilevel=391,quality=epic,stats=3292armor_420str_689sta_316exp_251crit,gems=40str_40str_20str,enchant=55crit_190ap
feet=warboots_of_mighty_lords,type=plate,ilevel=378,quality=epic,stats=2490armor_282str_454sta_197crit_187hit,reforge=hit_mastery,gems=40str_10str,enchant=35mastery
wrists=earthcrack_bracers,heroic=1,type=plate,ilevel=391,quality=epic,stats=1646armor_256str_384sta_158haste_178crit,reforge=haste_exp,gems=67str,enchant=50str
hands=gauntlets_of_the_molten_giant,heroic=1,type=plate,ilevel=391,quality=epic,stats=2351armor_322str_513sta_209hit_227mastery,reforge=mastery_crit,gems=20str_20crit_67str_10str,enchant=50str
finger1=dargonaxs_signet,heroic=1,ilevel=379,quality=epic,stats=229str_344sta_113crit_153mastery,gems=20str_20crit_10str
finger2=obsidian_signet_of_the_avengers,ilevel=391,quality=epic,stats=236str_384sta_195crit_110hit,reforge=hit_exp,gems=40str_10str
trinket1=apparatus_of_khazgoroth,heroic=1,ilevel=391,quality=epic,stats=433str
trinket2=vessel_of_acceleration,ilevel=384,quality=epic,stats=406str,equip=onattackcrit_82crit_5stack_20dur
back=bladed_flamewrath_cover,ilevel=378,quality=epic,stats=695armor_227str_341sta_173haste_115exp,reforge=haste_crit,enchant=65crit
main_hand=zoids_firelit_greatsword,heroic=1,ilevel=391,quality=epic,stats=440str_689sta_320crit_264haste,reforge=haste_exp,gems=20str_20hit_10str,enchant=landslide,weapon=sword2h_3.60speed_2418min_3628max
ranged=giantslicer,ilevel=378,quality=epic,stats=128str_192sta_81exp_88hit,reforge=hit_crit,weapon=thrown_2.10speed_1250min_1875max
# Gear Summary
# gear_strength=5982
# gear_agility=20
# gear_stamina=6661
# gear_intellect=20
# gear_spirit=20
# gear_attack_power=190
# gear_expertise_rating=780
# gear_hit_rating=963
# gear_crit_rating=2709
# gear_haste_rating=631
# gear_mastery_rating=751
# gear_armor=22038
# meta_gem=reverberating_shadowspirit
# tier12_2pc_melee=1
# tier12_4pc_melee=1
# trinket1=apparatus_of_khazgoroth,heroic=1
# main_hand=zoids_firelit_greatsword,heroic=1,weapon=sword2h_3.60speed_2418min_3628max,enchant=landslide
# ranged=giantslicer,weapon=thrown_2.10speed_1250min_1875max

# User-specified persistent global and player parms will set here.

Reported by arexdramon on 2011-09-17 21:41:53

[navv1234]

Btw, if there are any other files necessary to running Simulationcraft with the GUI
other than the QT dll's and the util_scripts + imageformats folders, then say so. I've
been trying to clean up my simulationcraft folder of any unneeded source-specific files.

Also the latest release (not build from svn, but pre-built release version 420-9) does
not crash. I'll see if I can't keep on building and see where it broke.

Edit: Never mind. The build that made release version 420-9 still had the bugged vcproj
file, so I'm unable to build. I wonder how you were able to build with a bugged vcproj
file..

Reported by arexdramon on 2011-09-17 22:07:24

[navv1234]

The build went out as I use the 2010 version, not the 2008. The bug existed in the 2008
build script, even then fixing the build is adding one line to the file.

We don't generally offer support for errors that exist in SVN as they're hard to follow
unless you're running the HEAD revision. I won't have access to my QT build system
until Monday, so you'll have to wait until then or until someone else is able to fix
it, assuming you don't before hand. There's nothing new in the SVN that should have
broken builds from the 420-9 release, so I have no clue what could be causing the issue.

Reported by swbusche on 2011-09-18 04:42:18

[navv1234]

I'll try using 2010 (as I have that also) & see if it changes anything. What I can say
is that I personally have followed the build instructions to the letter; and have experience
doing so on countless numbers of projects.

If that doesn't work, I'll go back as far as I can and find the last working revision
that I can build and try and work my way up. That being said, you or someone else may
find the cause and have fixed it by then.

Reported by trigunflame on 2011-09-18 10:22:37

[navv1234]

Well, I've verified that it builds & operates cleanly under 2010 (you may want to push
a 2010 version "simqt10.sln" to the trunk, like you have for the console solution;
if you're not planning on supporting 08 builds anymore).

Reported by trigunflame on 2011-09-18 12:25:47

[navv1234]

We do support MSCV 08 builds, there was an error, the error has been fixed, the instructions
to do so are in comment 6. The build error has nothing to do with a runtime error,
which is what this issue is about.

Reported by swbusche on 2011-09-18 13:31:35

[navv1234]

http://www.youtube.com/watch?v=jMQYQ8Ubprk

Cap of me build from start to finish, including source pull.
Again, only in 08' does this happen & I haven't the slightest idea why.

Reported by trigunflame on 2011-09-18 14:27:22

[navv1234]

@SW, just to be clear - I never had a problem with building on either version. 
Simply confirming that the executable built with 08 crashes & the one built with 10
works fine.

If you need anything else, let me know.

Reported by trigunflame on 2011-09-18 14:40:09

[navv1234]

The failing DLL, msvcr90.dll, is from the 08 version, what's causing it to fail, but
work with msvcr100.dll (2010), is beyond me. I don't have access to a 2008 version
myself, but one way would be to test building 420-8, then 7, etc, until you find where
you can build it, and then see if you can find the specific revision, but that's a
lot of testing.

Maybe someone else can shed some insight on it.

Reported by swbusche on 2011-09-18 15:41:04

[navv1234]

Most likely it's the latest changes to threading, but that's only a guess.

Reported by swbusche on 2011-09-18 15:43:04

[navv1234]

After an hour or two of testing several revisions, I might have found the culprit. 
I was able check out HEAD and revert changes from r9571, resulting in an exe that doesn't
crash; beyond that, I still have no clue on the specific problem causing code; I'll
leave that to you.

Reported by trigunflame on 2011-09-19 06:01:41

[navv1234]

Looked a little further in r9571, and it seems the following change in sc_stats.cpp
is causing the runtime vector subscript out of range error.

Prior to r9571: timeline_amount.resize( index + 1 );
Changed to in r9571: timeline_amount.resize( index * 2 );

At the time of crash, int index = 0.

Reported by trigunflame on 2011-09-19 06:21:46

[navv1234]

Some or all of these problems may be fixed in r9621.

Reported by cartec69 on 2011-09-20 01:56:52

• Status changed: Accepted

[navv1234]

Yep, not crashing anymore on my end.

Reported by trigunflame on 2011-09-20 02:27:49

[navv1234]

1/3 posters down! Arexdra, Blu, please post if this fix works for you as well, so I
can close this issue out. Major kudos to Trigun for finding the bug - I owe you a beer.

Reported by cartec69 on 2011-09-20 03:16:10

[navv1234]

WFM !!

Thanks you guys, I love you :D

With only 2 warnings, but I don't believe they are important:

1>simcqt - 0 error(s), 2 warning(s)
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

1>sc_window.cpp
1>.\qt\sc_window.cpp(1056) : warning C4996: 'fopen': This function or variable may
be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS.
See online help for details.
1>        C:\Program Files\Microsoft Visual Studio 9.0\VC\include\stdio.h(237) : see
declaration of 'fopen'

1>Linking...
1>LINK : warning LNK4068: /MACHINE not specified; defaulting to X86

Reported by blubibulga on 2011-09-20 07:03:30

[navv1234]

Microsoft claims that their fopen_s function is somehow more secure than the standard
fopen because it returns the value of errno directly in addition to setting the global
variable. Warning C4996 may have semantic meaning for other cases, but for fopen it's
pure marketing.

Reported by cartec69 on 2011-09-20 20:24:22

[navv1234]

Does not crash for me anymore.

Reported by arexdramon on 2011-09-22 20:13:25

[navv1234]

3 for 3. This fix is live in 422-1, closing.

Reported by cartec69 on 2011-09-22 20:17:47

• Status changed: Verified

[navv1234]

Issue 805 has been merged into this issue.

Reported by cartec69 on 2011-10-17 05:12:37