Leader of the Pack Not Returning Health/Mana

[navv1234]

Originally reported on Google Code with ID 913

What steps will reproduce the problem?
1. Load a druid bear or cat simc file and simulate with debug logging enabled
2. Observe the results

What is the expected output? What do you see instead?
The "Leader of the Pack" talent states...

"In addition, your melee critical strikes in Cat Form and Bear Form cause you to heal
for 4% of your total health and gain 8% of your maximum mana.  This effect cannot occur
more than once every 6 sec."

I would expect to see on melee crits at least 6 secs apart a gain of 4% health and
8% mana.  This effect isn't occurring.  I went through the log files generated looking
at the crits, and this effect isn't proccing.

What version of the product are you using? On what operating system?
SimulationCraft 422-3 on Mac OS 10.7.2

Please provide any additional information below.
I imagine this could work something like the solution for vampiric embrace, but taking
into effect the 6sec CD?

Reported by lightfoot on 2011-10-21 16:27:45

[navv1234]

Thanks, I'll try and get to this between panels on Blizzcon this weekend.

Reported by swbusche on 2011-10-21 17:43:22

• Status changed: Accepted

[navv1234]

This issue was closed by revision r10012.

Reported by swbusche on 2011-10-22 04:11:25

• Status changed: Fixed

[navv1234]

Hello, I just downloaded this fix from subversion and I found a few things...

1.) It's proccing from Demoralizing Roar.  I ran the log file, see below...

0.00     [[TOONNAME]] demoralizing_roar hits Fluffy_Pillow for 0 physical damage (crit)
0.00     [[TOONNAME]] gains 0.00 (0.00) health from lotp_health (0.00/0.00)
0.00     [[TOONNAME]] gains 0.00 (0.00) mana from lotp_mana (0.00/0.00)
0.00     [[TOONNAME]] gains 5.00 (5.00) rage from primal_fury (10.00/100.00)
...
151.63   [[TOONNAME]] demoralizing_roar hits Fluffy_Pillow for 0 physical damage (crit)
151.63   [[TOONNAME]] gains 0.00 (0.00) health from lotp_health (-5092200.00/0.00)
151.63   [[TOONNAME]] gains 0.00 (0.00) mana from lotp_mana (0.00/0.00)
151.63   [[TOONNAME]] gains 5.00 (5.00) rage from primal_fury (95.00/100.00)

For that matter I'm pretty sure 'Primal Fury' shouldn't proc from that either.

I also found another irregularity.  It doesn't seem to be bringing back any health
or mana.  See below...

28.24    [[TOONNAME]] maul hits Fluffy_Pillow for 82 physical damage (crit)
28.24    [[TOONNAME]] gains 0.00 (0.00) health from lotp_health (-787200.00/0.00)
28.24    [[TOONNAME]] gains 0.00 (0.00) mana from lotp_mana (0.00/0.00)
28.24    [[TOONNAME]] gains 5.00 (5.00) rage from primal_fury (75.00/100.00)

Reported by lightfoot on 2011-10-22 13:19:58

[navv1234]

You can disregard the not bringing back any health or mana one.  That's coming if I
run a toon that is under lvl 60, and that seems to be another bug altogether.  Now
those toons show no health/mana whatsoever.  However, under 4.2.2-2 they showed it
fine.

Reported by lightfoot on 2011-10-22 14:31:43

[navv1234]

I have a fix for the first part. Why it's not returning any health/mana for the second
is because you have negative health and 0 mana. How that happens, I have no clue.

Reported by swbusche on 2011-10-22 14:53:10

[navv1234]

Part 2 should look more like this:

2.10     Druid_Tank thrash hits Fluffy_Pillow for 7586 bleed damage (crit)
2.10     Druid_Tank gains 5980.92 (5980.92) health from lotp_health (149330.12/149523.00)
2.10     Druid_Tank gains 0.00 (2097.27) mana from lotp_mana (26215.90/26215.90)
2.10     Druid_Tank gains 5.00 (5.00) rage from primal_fury (15.18/100.00)

Reported by swbusche on 2011-10-22 14:54:39

[navv1234]

I have my fix in SVN, if you're still getting the weird negative health and zero mana
gains, attach your profile please.

Reported by swbusche on 2011-10-22 15:06:30

[navv1234]

I know how I did it, it was my own dumb mistake.  I was feeding in a race that wasn't
a value.  I had [[TOONRACE]] in my file to be replaced and I wasn't replacing it. 
So it was feeding in a bogus race and not setting up my stats correctly.

A little background, I'm writing a wrapper program for SimC that will go through all
the dungeons and level a guild and be a little silly.  Just a crazy idea I had to simulate
a group of players almost from the beginning.  It's a blast so far to put together,
but it's making me test lvl 20-85 from the players and test every ability.  So that's
where I'm running across some of these.  Sorry for the confusion for letting my own
mistake slip in on the "health/mana return" one there.

Reported by lightfoot on 2011-10-22 15:09:33

[navv1234]

We don't have any base stats/mana/health values for lower levels, so if you want to
sim anything you'd have to get those numbers ( ingame naked, calculating out all the
bonuses ) and feed them to the sc_const_data.inc file.

That's also the reason why you aren't seeing some resource info for them right now,
because resources with a base value equal to zero are filtered out in some report sections.

Reported by philoptik on 2011-10-23 16:25:55