search

simulkade / JFVM.jl

A simple finite volume tool for Julia
Other
43 stars 13 forks source link

Support for 3D spherical coordinate #2

Open simulkade opened 9 years ago

simulkade commented 9 years ago

Some functions must be written for 3D spherical coordinate (r, \theta, \phi)

gjwilkie commented 6 years ago

Could one just multiply the equation through by the Jacobian of whatever coordinates you're using (in this case, r^2*sin(theta) ) and include the appropriate factors inside the derivatives?

simulkade commented 6 years ago

Hi George,

Most probably not. My guess is something can go wrong with the way I handle the cell and face positions. You can give it a try of course. Do you have an example?

On Thu, Oct 11, 2018 at 5:20 PM George Wilkie notifications@github.com wrote:

Could one just multiply the equation through by the Jacobian of whatever coordinates you're using (in this case, r^2*sin(theta) ) and include the appropriate factors inside the derivatives?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/simulkade/JFVM.jl/issues/2#issuecomment-428994631, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy1xjDooVCXewFBv_qBoSjTGA8zku_Zks5uj2HMgaJpZM4DUN1G .

simulkade commented 6 years ago

BTW, I have implemented the 1D spherical in FVTool. You can find an example here