search

simulot / immich-go

An alternative to the immich-CLI command that doesn't depend on nodejs installation. It tries its best for importing google photos takeout archives.
GNU Affero General Public License v3.0
1.63k stars 49 forks source link

Fix issue with specifying device UUID #139

Closed mmomjian closed 8 months ago

mmomjian commented 8 months ago

In importing pictures, I have found that the -device-uuid= flag does not change the deviceId on the imported item into immich. I believe this is due to the variable name not matching the case as it is set in main.go. Are you able to confirm this?

mmomjian commented 8 months ago

I am not proficient in compiling golang but if you can send me a linux x86_64 binary I can check it on my end.

mmomjian commented 8 months ago

I believe I figured out how to compile it myself but the issue seems to persist - the deviceId is set as HOSTNAME regardless of the argument passed.

mmomjian commented 8 months ago

Update: if I hard code a value in asset.go:69, the deviceId appears in Immich, however it is getting lost somewhere before that point.

simulot commented 8 months ago

Thank for this PR.

Your change will have no effect on the problem. The problem is that the method SetDeviceUUID is never called.

mmomjian commented 8 months ago

Ah, I understand. Thanks for identifying the issue, sorry I couldn't find it. Do you prefer me to delete this PR or how do you want to handle the issue?

simulot commented 8 months ago

Up to you. You can either change the main.go, or close the PR and open an issue