search

simulot / immich-go

An alternative to the immich-CLI command that doesn't depend on nodejs installation. It tries its best for importing google photos takeout archives.
GNU Affero General Public License v3.0
1.63k stars 49 forks source link

update create time when remote does not have one #183

Open russelltg opened 6 months ago

russelltg commented 6 months ago

I uploaded my takeout directly naively, so all the times were incorrect. I updated this tool to be able to detect when the local and remote file are the same, but the local timestamp is older then the remote one, which indicates that the local one is better because bad timestamps seem to always be newer than real ones as they are fabricated from when downloaded from google or when uploaded to immich

There were other bugs that needed fixing for this--OriginalFileName already had the extension, so I removed the + ext. Also, the updateAsset API seems to have been updated since you added it.

Interestingly, the timeline does not update correctly after this, but the metadata when you click on an image is correct. I assume this is an immich bug...

simulot commented 6 months ago

Thanks for your PR. I'll review it during the week end

simulot commented 6 months ago

Before going further, have have checked if the problem wasn't created by time zone issues? This is common that digital cameras doesn't set the time zone. Another case: the phone store the date as UTC, and depending you time zone, the local time can be behind or ahead