search

simulot / immich-go

An alternative to the immich-CLI command that doesn't depend on nodejs installation. It tries its best for importing google photos takeout archives.
GNU Affero General Public License v3.0
1.2k stars 36 forks source link

fix: Do not require value for version call #352

Closed kai-tub closed 3 days ago

kai-tub commented 4 days ago

The current -version call requires an additional "value" to exist, although it is not used. I assume it should've been the BoolFunc function that does not require a value to be set. But the output still contains the default header, so the output of immich-go -version command looks like:

immich-go  0.18.2, commit 4fa283d1a41f33c83df71618f1115e737b1e19fc, built at 2024-07-03T08:48:52Z
immich-go 0.18.2

Is this the expected behaviour?

simulot commented 4 days ago

Thanks. I missed that! The expected behavior is:

immich-go 0.18.2
kai-tub commented 2 days ago

Hey, thanks for merging it and sorry for not replying fast enough to finish it myself. And thanks for pushing on the branch and not merging from a different branch! 🙏

Would you consider tagging a new release with the fix? Then I would go ahead and update the package in nixpkgs 👍

PS: Have you thought about adding a "buy me a coffee" link to the readme?

simulot commented 2 days ago

You're welcome!

Would you consider tagging a new release with the fix? Then I would go ahead and update the package in nixpkgs 👍

I'm working on a forcing the use the google photo metadata. Due date this weekend.

PS: Have you thought about adding a "buy me a coffee" link to the readme?

Not. Should I?

kai-tub commented 2 days ago

I'm working on a forcing the use the google photo metadata. Due date this weekend.

Nice! No pressure though. 👍

I think having such a link wouldn't hurt 🤷‍♂️ I would like to buy you one.

simulot commented 2 days ago

I'll check how it works