simulot / immich-go

An alternative to the immich-CLI command that doesn't depend on nodejs installation. It tries its best for importing google photos takeout archives.
GNU Affero General Public License v3.0
1.91k stars 55 forks source link

immich-go import seems to finish early? #417

Closed williamkray closed 3 months ago

williamkray commented 3 months ago

executing immich-go to import google takeout archives seems to work fine, however the process consistently stops and says "Upload completed" after only processing through about 75% of the content.

Multiple subsequent runs of the program processes the files again, generally finding that most of the files have already been handled, but i'm getting about 30 more files uploaded each time, again each run stops around 75-80% complete.

running on pop_os linux, v 0.20.1. i only realized this was an issue because i saw other comments on the immich subreddit saying the same thing.

williamkray commented 3 months ago

example of one of my recent runs (this is the 5th or 6th time i've run the same import command):

image

simulot commented 3 months ago

This is almost fixed with version 0.21

driftywinds commented 3 months ago

This is almost fixed with version 0.21

I know this has been fixed but could you tell me what the problem behind this behaviour was?

simulot commented 3 months ago

The problem was caused by the difficulty to count how many file among the those scanned need to be uploaded. There are duplicates of many kinds, lives photo + video that count for 2 files, but one upload, files that are already on the server ... etc...

So the 100% of files is definitively not the total of scanned files. In your case, all files to be uploaded was representing 75% of the number of files that system had the intention to upload. I hope I get it right this time.