simulot / immich-go

An alternative to the immich-CLI command that doesn't depend on nodejs installation. It tries its best for importing google photos takeout archives.
GNU Affero General Public License v3.0
1.83k stars 55 forks source link

Preserve descriptions of duplicates #462

Open emjaymeow opened 2 months ago

emjaymeow commented 2 months ago

When running de-duplication, would it be possible to preserve the description of the deleted duplicates by also adding the description to the preserved image?

Example:

Lower quality(LQ) google photos image in album "Dog" with description: "This is a cute dog" Higher quality(HQ) original of the same image not in any album with no description.

Current de-duplication behaviour:

Desired de-duplication behaviour:

emjaymeow commented 2 months ago

I also just noticed the same happens on upload, when adding a google takeout zip with descriptions on the images. The descriptions get lost when my immich library already has the same images in higher quality.

It would be nice if the decription would be added to the higher quality version if it has none.

simulot commented 2 months ago

That makes sense. On the other hand, if you run the import several times, the description will accumulate descriptions.

I should add a parameter to control how takeout comments are handled:

emjaymeow commented 2 months ago

True, that would be nice. And if "add to existing description" is chosen, maybe compare the strings and if they are exactly the same then leave them be. And if they are different then merge/add them. Or make that another option?

Btw, thank you for this great tool and your efforts!

simulot commented 2 months ago

The parameter list becomes a mess. I work on restructuring the command line argument parsing before. Stay tuned.