search

simulton / QSchematic

A library that allows creating diagrams such as flowcharts or even proper engineering schematics within a Qt application.
https://simulton.com
MIT License
231 stars 60 forks source link

apply QT_NO_KEYWORDS #68

Closed IMAN4K closed 4 months ago

IMAN4K commented 4 months ago

In the case of using 3rd parties like KDBindings to remove name clashes simply QT_NO_KEYWORDS must be applied.

Best Regards, Iman.

Tectu commented 4 months ago

I'm quite okay with the keyword changes. However, I'm wondering about the add_definitions(). I feel like this is something that the consuming target should define if necessary. In any case, that should be done via target_compile_definitions() instead.

IMAN4K commented 4 months ago

@Tectu Yeah it could be an option