simuons / rules_clojure

Clojure rules for Bazel
Apache License 2.0
34 stars 8 forks source link

Switch test to use java_executable_runfiles_path #11

Closed markdingram closed 4 years ago

markdingram commented 4 years ago

Fixes #10

simuons commented 4 years ago

Thanks! I'll take care and merge it on weekend

simuons commented 4 years ago

Thanks again for PR! I'm going to merge it. Still I'm trying to understand what could go wrong with usage of java_common.JavaRuntimeInfo.java_executable_exec_path. Would something break that could be covered with tests or it's just incorrect according to docs. I saw few issues on github related to java_executable_exec_path I guess I'll need to figure that out later.