Crash when exiting atom

simurai / one-vibrancy

Vibrancy effect for Atom One themes

MIT License

205 stars 10 forks source link

Crash when exiting atom #16

Open julianveerkamp opened 5 years ago

julianveerkamp commented 5 years ago

Whenever I exit Atom a crash occurs, but only if the one-vibrancy Plugin is installed.
It doesn't matter if I exit via CMD+Q or use the Red-X.
Happens on both macOS 10.14 and 10.13.6
This is particularly annoying since I have to reopen every Project again, after Exiting Atom.

simurai commented 5 years ago

Yes, I can reproduce this too. Reloading Atom with one-vibrancy enabled causes Atom to crash. I wonder what changed?

julianveerkamp commented 5 years ago

I’ve also read that Electron has some issues with vibrancy, but I’m not sure if those issues are connected to this one.

Sent from my iPhone

On 15. Oct 2018, at 03:54, simurai notifications@github.com wrote:

Yes, I can reproduce this too. Reloading Atom with one-vibrancy enabled causes Atom to crash. I wonder what changed?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

scherii commented 5 years ago

@simurai It might be electron version 2 that caused the macOS vibrancy related crashes. And it seems that https://github.com/atom/atom/issues/17819 will fix it. I couldn't get my atom build to run yet to verify this though.

simurai commented 5 years ago

@scherii It might be electron version 2 that caused the macOS vibrancy related crashes.

Yeah, sounds like this issue: https://github.com/electron/electron/issues/12068. Should be fixed in Electron 3.0. But not sure when it lands in Atom.

scherii commented 5 years ago

I just built the latest Atom from electron-3-0 branch on macOS 10.14.2 and can confirm that vibrancy works again.

julianveerkamp commented 5 years ago

This appears to be fixed in Atom version 1.39.1