search

simvue-io / python-api

Simvue Python API
https://docs.simvue.io
Apache License 2.0
4 stars 0 forks source link

Added heartbeat timeout option to Run #496

Open kzscisoft opened 3 weeks ago

kzscisoft commented 3 weeks ago

Adds the timeout argument to Run.init to specify the timeout period for the run where setting it to None disables the timeout.

Closes #494

james-panayis commented 1 week ago

Would be nice if there was a test that tried the case where the timeout is set to None (and ideally then waited over 180 seconds to confirm that the run doesn't end up in the lost state).

kzscisoft commented 1 week ago

@james-panayis The issue with that is it will be a significant extension to CI execution time

james-panayis commented 6 days ago

@kzscisoft if you did the wait then sure, that'd increase the CI time. But just confirming that a run can actually be created with timeout None would not take especially long. I mostly would just like a test to confirm that the server will correctly interpret the request as an instruction to create a run.