search

sinaatalay / rendercv

The engine of the RenderCV App
http://docs.rendercv.com
MIT License
1.75k stars 116 forks source link

improve boilerplate content in sample_content.yaml #118

Closed 1993CRV closed 2 months ago

1993CRV commented 2 months ago

Simplify and improve boilerplate content

sinaatalay commented 2 months ago

Thank you. I will merge it, but the tests fail because the website doesn’t have a valid HTTP URL (https:// has been removed).

The https part is never printed on the resume, but we need it to ensure the link's validity in the PDF. So, we should add it back to the YAML. PDF won’t show the https part.

1993CRV commented 2 months ago

Thank you. I will merge it, but the tests fail because the website doesn’t have a valid HTTP URL (https:// has been removed).

What about the trailing / at the end of certain URLs? Will those automatically be omitted?

The https part is never printed on the resume, but we need it to ensure the link's validity in the PDF. So, we should add it back to the YAML. PDF won’t show the https part.

What about www. in URLs? Will those also be omitted? For reference, take a look at each of the URLs here https://imgur.com/7lJTTsN

I disagree with adding these back to the YAML.

sinaatalay commented 2 months ago

www is the name of a subdomain; it's up to people whether to use it or omit it. Some people make their website only available to the www subdomain. Therefore, it's not being omitted automatically.

Why do you disagree with adding https? There is a valid reason for making the URL a valid HTTP URL: We must make sure each link goes to a valid webpage. The PDF looks the same, so I don't understand the issue.

Also, trailing / is omitted automatically as well. These can be easily tested with the rendercv render command.

1993CRV commented 2 months ago

www is the name of a subdomain; it's up to people whether to use it or omit it. Some people make their website only available to the www subdomain. Therefore, it's not being omitted automatically.

Why do you disagree with adding https? There is a valid reason for making the URL a valid HTTP URL: We must make sure each link goes to a valid webpage. The PDF looks the same, so I don't understand the issue.

Also, trailing / is omitted automatically as well. These can be easily tested with the rendercv render command.

I suggest simply making the website entry Markdown

See commit https://github.com/sinaatalay/rendercv/pull/118/commits/0b9456dca82b4917f01415c77465c0988d08023a

sinaatalay commented 2 months ago

Maybe you can open an enhancement issue for that, and we can discuss it under the issue. I don't understand why you would request that since the PDF automatically has the clean URL. I don't understand what you didn't like in the output.