search

sinaatalay / rendercv

The engine of the RenderCV App
http://rendercv.com
MIT License
1.92k stars 139 forks source link

URL not displayed in publication entry #138

Closed samvanstroud closed 3 months ago

samvanstroud commented 3 months ago

Describe the bug When adding the field url to a PublicationEntry, no URL is displayed. I would expect to see a hyperlinked URL here, similar to when using a DOI. If disable_external_link_icons: true, then the link dissappears entirely.

To Reproduce

    publications:
      - title: 3D Finite Element Analysis of No-Insulation Coils
        authors:
          - Frodo Baggins
          - '***John Doe***'
          - Samwise Gamgee
        url: https://github.com/
        date: 2004-01

Screenshots

Screenshot 2024-07-23 at 13 40 07
samvanstroud commented 3 months ago

It might also be nice to have the option to hide the link but make the publication title clickable instead

sinaatalay commented 3 months ago

Thank you! This has been addressed in #128. It will be fixed in v1.13 (I plan to release it today.)

sinaatalay commented 3 months ago

It might also be nice to have the option to hide the link but make the publication title clickable instead

This can be achieved by using Markdown links as shown below:

- title: [This is a title](https://example.com)
...
samvanstroud commented 3 months ago

Great thanks! Apologies for the noise!

samvanstroud commented 3 months ago

Although for your second suggestion I would prefer a configuration option. It would be much cleaner on the yaml side and also would avoid mixing up DOIs and URLs if a DOI field is defined. It would also be nice to have the abilty to display the external link icon next to the publication title. What do you think?

sinaatalay commented 3 months ago

Although for your second suggestion I would prefer a configuration option.

I wouldn't say I like using configuration options because they increase the size of the templates and make tests even more difficult. Even the 'url' field was not properly tested, as this issue demonstrates.

Of course, I always prioritized the user experience over development issues; therefore, in v1.9, I took a new approach to allow users to tweak their entries: I gave the users complete control of the templates. You can quickly achieve what you want by tweaking the PublicationEntry.j2.tex file that comes from the rendercv new command (see here.) Overriding built-in themes is described here.

It would also be nice to have the abilty to display the external link icon next to the publication title.

This can be achieved with a blank Markdown link:

- title: This is a title [](https://example.com)
...
samvanstroud commented 3 months ago

Thanks for the explaination and solutions!