search

sinaatalay / rendercv

The engine of the RenderCV App
http://docs.rendercv.com
MIT License
1.75k stars 116 forks source link

Raise error only if status code is 404 #3

Closed LabAsim closed 10 months ago

LabAsim commented 10 months ago

Hello @sinaatalay,

i opened a new pull request with only 1 commit, which incorporates the changes that you mentioned. The function will only raise a ValueError only if the status code is 404 (Not found).

sinaatalay commented 10 months ago

Thank you for finding the bug and fixing it. This is the first public contribution to RenderCV 😃

LabAsim commented 10 months ago

It's also my first merged pull request, thank you!