search

sinaatalay / rendercv

A LaTeX CV/Resume Framework
http://docs.rendercv.com
MIT License
1.67k stars 108 forks source link

fix: remove example summary from template #53

Closed tcinbis closed 4 months ago

tcinbis commented 4 months ago

Hey @sinaatalay,

thank you for this amazing tool, I am really liking what I have seen so far! Just a minor fix since I was experimenting with the latest code changes from master. I tried to infer what the correct template should look like from your other changes. I hope it is correct.

Best, Tom

tcinbis commented 4 months ago

Judging from the tests, not quite... but at least with my demo CV the summary worked fine with version 1.6, but now only includes the sample summary that is currently in the classic/TextEntry.j2.tex template.

Seems like the testdata needs to be fixed as well.

sinaatalay commented 4 months ago

Thank you for finding this! Your approach was spot on. I am merging it.

The tests failed due to mismatches between the RenderCV's output and reference outputs in the testdata folder. Since a template has been updated, indeed, the reference outputs in the testdata folder should also be updated.

A note about tests:

In some of the tests:

When the testdata folder needs to be updated, it can be manually regenerated by setting update_testdata to True in conftest.py and running the tests.

Whenever the testdata folder is generated, the files should be reviewed manually to ensure everything works as expected. But sometimes, mistakes like this one can go unnoticed. Therefore, any ideas about other testing approaches would be appreciated.