search

sinabe / dolibarr-swissqr

Swiss QR invoice for Dolibarr
7 stars 3 forks source link

The payment reference type "NON" does not match with the iban type #1

Open acopernic opened 1 year ago

acopernic commented 1 year ago

Hi, Thanks for the job. I've installed the module, etc. and whatever the version tested I've always the same issue. The iban is specific (QR-IBAN) Any idea why there's this error. Thank you

benvia commented 1 year ago

Hello,

Thank you for your feedback.

The code in the repository seem to work with classic IBAN and without reference. If you try QR-IBAN or adding reference the code must be updated.

QrBill\DataGroup\Element\PaymentReference::TYPE_QR,$referenceNumber

I can have a look to implement this but I can't test it.

acopernic commented 1 year ago

Hi,

Thanks. Normally we should have on qr-iban with no reference. I will take a look to see why this does not generate any pdf (I changed the iban)

Jan 4, 2023 13:34:38 benvia @.***>:

Hello,

Thank you for your feedback.

The code in the repository seem to work with classic IBAN and without reference. If you try QR-IBAN or adding reference the code must be updated.

QrBill\DataGroup\Element\PaymentReference::TYPE_QR,$referenceNumber

I can have a look to implement this but I can't test it.

— Reply to this email directly, view it on GitHub[https://github.com/sinabe/dolibarr-swissqr/issues/1#issuecomment-1370873939], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AERFRD6KWCA5ZK4O6DULAGTWQVU5ZANCNFSM6AAAAAATQOHUE4]. You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AERFRD7E6DFOECVDPOAG7STWQVU5ZA5CNFSM6AAAAAATQOHUE6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSRWXQFG.gif]

benvia commented 1 year ago

Hi,

You can contact Sinabe so that we can investigate further.

Best regards Benoit

benvia commented 1 year ago

This is fixed with the last version of the repo. I added the support for QR-IBAN and reference.