sinara-hw / FMC_Shuttler

16-channel 125MS/s 16bit DAC in FMC form factor.
15 stars 4 forks source link

Schematic review: FMC card #18

Closed dhslichter closed 3 years ago

dhslichter commented 3 years ago

Again, looks good overall @gkasprow. Comments and questions:

More to come tomorrow, will edit top post to add.

gkasprow commented 3 years ago

The FSADJ are already 10ppm. I replaced with 2k0

gkasprow commented 3 years ago

DVDD is not connected intentionally. I drive DVDDIO from VADJ to make sure it works with 1.8 and 2.5V FMC signaling.

gkasprow commented 3 years ago

Indeed, there is a missing LC filter between VADJ and VADJ_BUF

gkasprow commented 3 years ago

Won't the bias currents of both amps compensate each other?

gkasprow commented 3 years ago

all DACs and their clocks are within the same FPGA banks. FMC says which clocks are for which data lines. Some carriers split LA lines between 2 banks - one must make sure the right clocks are used to clock these data

gkasprow commented 3 years ago

R34, R38 = 249R; R34, R37 = 105R; all are 10ppm, 0603 resistors

gkasprow commented 3 years ago

We are already using REF_0V625 for AFE :) I will rename the REF signal to AFE_REF to avoid confusion

gkasprow commented 3 years ago

I removed the voltage translation chips between FPGA and DAC because the DAC already supports the 1.8-3.3V operation (VADJ range) and the buffer skew reduces the timing budget

dhslichter commented 3 years ago

DVDD is not connected intentionally. I drive DVDDIO from VADJ to make sure it works with 1.8 and 2.5V FMC signaling.

OK, I got confused there.

Won't the bias currents of both amps compensate each other?

They are not super well matched: -11 uA typ, ranges between -17 uA and -4 uA. My suggestion was primarily about getting pads in place (can populate with 0R) to allow this to be changed later if desirable.

all DACs and their clocks are within the same FPGA banks. FMC says which clocks are for which data lines. Some carriers split LA lines between 2 banks - one must make sure the right clocks are used to clock these data

My question is -- is this a function of the specific carrier board, or is it specified in VITA 57.1? My worry is that different FMC carrier cards might implement differently, and now you have some DACs/clocks split across banks.

dhslichter commented 3 years ago

Still haven't completed all aspects of schematic review, will try to get it done tonight if possible.

gkasprow commented 3 years ago

Yes, clock/banks arrangement is defined by VITA specification

gkasprow commented 3 years ago

I routed the PCB - it still needs cosmetics, DRC and SI/PI checking

gkasprow commented 3 years ago

the pdf is in releases

gkasprow commented 3 years ago

the noise analysis obraz

dhslichter commented 3 years ago

Some questions -- the current source I1 is not the right value (should be 10 mA), also the DAC can be modeled as a current noise source with 38 pA/rtHz (datasheet). Not sure where the 1/f knee is. And the output noise shown here is differential noise, referred to the output?

I think that the values of R1 and R3 should be 50 ohm, not 100 ohm?

filipswit commented 3 years ago
gkasprow commented 3 years ago

the opamp has a drift of 3nA/K and max input current of -11...-17uA. If we don't compensate it, the input offset value would be -600uV which is much higher than the typical Vos of 28uV The bias currents will compensate to some extent, but if one of the inputs has -11uA and another -17uA, the imbalance would be still 6uA, which will end up with a much higher offset than Vos. So let's add resistors at the positive input of opamps. I have to fit them somehow.

OK, so I added the noise source of the DAC. I added the FB capacitors as well. Here are the simulation files

obraz

gkasprow commented 3 years ago

after adding bias current compensation resistors obraz