sinara-hw / Kasli-SOC

Xilinx ZynQ(R) version of Kasli FPGA controller.
6 stars 6 forks source link

changelog v1.1 #69

Open filipswit opened 2 years ago

filipswit commented 2 years ago

edit

gkasprow commented 2 years ago

@filipswit did you consult moving the EEPROMs to separate I2C interface with software guys?

filipswit commented 2 years ago

no, but default EEPROM, IC5 is not moved. We can't add aditional footprint - https://github.com/sinara-hw/Kasli/issues/97, because of conflict with SFP3 addres, so I made same solution as in Kasli v2.0.2

kaolpr commented 2 years ago

I believe there was some discussion on version naming convention and patch number (according to ..) was to be reserved only for compatible component replacements. Here I can see some issue fixes.

If such discussion was not written (honestly, don't remember) maybe we should write down rules on that.

filipswit commented 2 years ago

@gkasprow and @kaolpr so should I rename it to v1.1?

gkasprow commented 2 years ago

yes, since it requires software changes, there must be new revision

gkasprow commented 2 years ago

The R110 and R100 could be replaced with E24 values image

kaolpr commented 2 years ago

yes, since it requires software changes, there must be new revision

@gkasprow How does it require software changes? IO expander has different address / registry map?

gkasprow commented 2 years ago

I2C EEPROM is connected in a different way

gkasprow commented 2 years ago

Before EEPROM was connected to shared bus, now it has a dedicated FPGA pins.

gkasprow commented 2 years ago

old-style regulators may not like 10uF at the output. I'd replace C376 with a 100nF capacitor and decouple it from LDOs 1uF caps with a few tens Ohm resistor. With a low ESR multi-uF load, it may oscillate.

gkasprow commented 2 years ago

@filipswit there is yet another issue that needs correction The MCP23017 expander port 7 must be output. So we need to swap DISABLE with FAULT I'd add a reistors for revision ID like in Kasli + one resistor for variant ID (a kind of expanders assembled) placed on the same sheet as I2C expanders

filipswit commented 2 years ago

decouple it from LDOs 1uF caps with a few tens Ohm resistor

You mean to place resistor (22R?) in series with 1uF at all LDOs Vbias inputs? BTW. I can place any different LDO if you have any other cheap and small.

The MCP23017 expander port 7 must be output. So we need to swap DISABLE with FAULT

image

So it looks that IC24 is fine (these are test points) and in IC25 I should swap 'VUSB_PRESENT_N', with 'SFP_0.LED'? image

I'd` add a reistors for revision ID like in Kasli + one resistor for variant ID (a kind of expanders assembled) placed on the same sheet as I2C expanders

I'll try to fit 3-4 rev ID bits and one variant ID resistor

gkasprow commented 2 years ago

decouple it from LDOs 1uF caps with a few tens Ohm resistor

You mean to place resistor (22R?) in series with 1uF at all LDOs Vbias inputs? BTW. I can place any different LDO if you have any other cheap and small.

just add a single 22Ohm (or similar already in the BOM) at the LDO output after the 100nF cap.

gkasprow commented 2 years ago

So it looks that IC24 is fine (these are test points) and in IC25 I should swap 'VUSB_PRESENT_N', with 'SFP_0.LED'?

yep, my bad

filipswit commented 2 years ago

Just verified the DS for this LDO, so it looks 470nF is absolute minimum i this case: image

Would it be good enough solution? image

gkasprow commented 2 years ago

OK, so you found better DS than me :)

gkasprow commented 2 years ago

No need for series resistor then.

filipswit commented 2 years ago

@gkasprow could you please look at the changes one more time?

kaolpr commented 1 year ago

@gkasprow @filipswit Can we assume v1.1 is reviewed?

kaolpr commented 1 year ago

@gkasprow Do you think https://github.com/sinara-hw/Kasli/issues/99 should be implemneted here?

gkasprow commented 1 year ago

SOT-23 version of EEPROM is still not available

gkasprow commented 1 year ago

please add note close to the I2C expanders that ASSY variant need to be updated.

gkasprow commented 1 year ago

why both EEPROMs are not mounted? image

gkasprow commented 1 year ago

Ah, I see, IC5 is connected instead... I'd add 24AA025E48T-I/OT assembly variant to it as well.

filipswit commented 1 year ago

yeep, it should be added. I've made issue to not forget about it in next revision https://github.com/sinara-hw/Kasli-SOC/issues/72.