sinara-hw / Phaser

Quad channel 1GS/s RF generator card with dual IQ upconverter and dual 5MS/s ADC and FPGA in EEM form factor
13 stars 4 forks source link

check loop filters #112

Open hartytp opened 3 years ago

hartytp commented 3 years ago

we should check the loop filters for the upconver and DAC before moving to the new release (e.g. to make sure that there isn't massive ringing etc).

jordens commented 3 years ago

Just the upconverters.

hartytp commented 3 years ago

why not the DAC? Have you checked that already and are happy with it?

jordens commented 3 years ago

There is no loop filter that could be checked.

hartytp commented 3 years ago

aah, okay, I'd forgotten that we're using the integrated loop filter.. Anyway, we should still check the close-in spectrum to check for servo bumps etc.

hartytp commented 3 years ago

We do plan to do this once we receive hardware with an upconverter. However, since it's only a BOM change, I'm happy sorting this out after the v1.1 boards have gone to print.

gkasprow commented 3 years ago

any conclusion here?

hartytp commented 3 years ago

haven't been able to check yet, but it shouldn't be a release blocker. Let's leave it open for now