search

sinara-hw / Pounder

PDH/phase lock signal generator for Stabilizer
5 stars 4 forks source link

rc2 #69

Closed hartytp closed 4 years ago

hartytp commented 4 years ago

Completed my review of rc2. Looks good!

63 needs to be resolved. The other open issues are non-critical as far as I'm concerned...

dtcallcock commented 4 years ago

Annotations at C82 are -16dBm. Should be -26dBm.

dtcallcock commented 4 years ago

Should there be some cool logos on the board?

Other than that, I also think it looks great.

dhslichter commented 4 years ago

image

dhslichter commented 4 years ago

Make some line art of this guy. He'd be pleased to be on the board :)

gkasprow commented 4 years ago

is that OK? obraz

hartytp commented 4 years ago

@gkasprow did you really take @dhslichter's comment seriously???? Can we scrap that plz?

On a more important note, I've seen jumpers like this lead to GHz-frequency oscillations before due to added input-output coupling image

gkasprow commented 4 years ago

Did U see the physical layout? I can use bigger footprint that woulf not change amplifier pads distance. We can also scrap it. I thought that you dont need this amp.

Pozdrawiam, G.Kasprowicz

From: hartytp notifications@github.com Sent: Friday, January 17, 2020 8:07:06 AM To: sinara-hw/Pounder Pounder@noreply.github.com Cc: Greg Kasprowicz gkasprow@gmail.com; Mention mention@noreply.github.com Subject: Re: [sinara-hw/Pounder] rc2 (#69)

@gkasprowhttps://github.com/gkasprow did you really take @dhslichterhttps://github.com/dhslichter's comment seriously???? Can we scrap that plz?

On a more important note, I've seen jumpers like this lead to GHz-frequency oscillations before due to added input-output coupling [image]https://user-images.githubusercontent.com/21218399/72594811-4e9e4580-3900-11ea-8d69-c0e84f81558b.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/sinara-hw/Pounder/issues/69?email_source=notifications&email_token=ABA75PXZQ666W7FPAO7UMHDQ6FRKVA5CNFSM4KEWKB7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJG357A#issuecomment-575520508, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABA75PQADUYTPA5DNRA22R3Q6FRKVANCNFSM4KEWKB7A.

hartytp commented 4 years ago

Did U see the physical layout?

No. I don't have altium right now and you didn't include the layout in the pdf. If you're happy with this then it's fine by me.

I thought that you dont need this amp.

We will want this amp for pounder (not for phaser, because it's a different application in our lab).