design review - Githubissues

sinara-hw / VHF_Amp

10-50MHz 10W RF amplifier for ion trapping applications

1 stars 0 forks source link

Open gkasprow opened 8 months ago

gkasprow commented 8 months ago

[x] the power detector thresholds are free floating: DET_TRH_REV; DET_TRH_FWD; maybe add another MAX DAC
[x] the JK flip flop RSTn and CLK are shorted together on top entity which don't make much sense to me
[x] don't we need some manual reset button?
[x] won't T4 saturate due to slight output current imbalance?
[x] add LEDs: overtemp, FWD interlock, REV interlock; power good, P12V, P48V
[x] missing P3V3_CPCIS source
[x] there are a lot ERC and DRC errors
[x] add connector labels: EEM, fan
[x] add power rail LEDs and testpoints; possibly all in same PCB region, look at KASLI-DIOT
[x] don't we need more vias under exposed copper? It's gonna make RF cages with outer shield/heatsink
[x] be careful with such pads; we can make panel cutout as we do in other designs
[x] milling cuts bottom layer
[x] copper cannot touch board edge - make 0.5mm clearance
[x] missing proper DIOT ESD strip and resistors - copy it from Kasli-DIOT
[ ]

shanasz commented 8 months ago

won't T4 saturate due to slight output current imbalance?

Core has Isat at least 7A, max current in Id of MRF101 in this application will be lower than 1A.

gkasprow commented 7 months ago

gkasprow commented 7 months ago

[x] Move the fine-tune input to the front panel, as in other designs like WENZEL_REF
[x] Make the reset button available from the front panel; use ordinary PB_TYCO_1-1825027-1
[x] Make sure the RF connectors are positioned as in newest Urukul - we want to re-use plastic distances
[x] Please add 3D model of the 6HP front panel (from Wenzel for example)
[x] please add 3D model of heatsink/shield
[x] when adding series resistor to the ADC input, remember about storage capacitor (10nF or so) to the ground at the ADC input.
[x] FIN1028 has failsafe feature - with inputs unconnected, it will produce 3.3V at the output holeind DET_RST permanently high. Add P-MOSFET in parallel to PB3 or inverter (like IC29)
[x] Where the power supply of IC29 is defined (VCC net) ? Add note on the schematic.
[x] put info about RF transformer ratios on the schematic
[x] IC33 will oscillate with ceramic caps, use 1..22u tantalum ones or add 100mOhm in series with C104

shanasz commented 7 months ago

IC33 will oscillate with ceramic caps, use 1..22u tantalum ones or add 100mOhm in series with C104

Changed to LT1117

shanasz commented 7 months ago

shanasz commented 7 months ago