search

sinasamavati / leptus

The Erlang REST framework
https://sinasamavati.com/leptus
MIT License
346 stars 50 forks source link

Replaced Makefile for erlang.mk. #31

Closed jfacorro closed 10 years ago

jfacorro commented 10 years ago

Building with erlang.mk doesn't work since with the current leptus's Makefile ends up writing all deps in its own deps subir.

sinasamavati commented 10 years ago

Thanks very much for contribution. I have some reasons to not add erlang.mk:

  1. the way I think about handling dependencies is a little different. In my humble opinion, once dependencies are built, they are built, so I wouldn't check dependencies every time I run make.
  2. checking dependencies every time makes the build system a little slow which doesn't seem good when I am working on Leptus. Sorry about that.

I could have reproduced the bug with the details you gave me. thank you. This is the commit which is supposed to fix the issue: https://github.com/s1n4/leptus/commit/9cd7a2cc6340c4b392fc6dcce2af21ff1eab8115

Could you please give it a try and let me know if everything works properly?

Thank you very much.

jfacorro commented 10 years ago

I can confirm it works, thanks for taking the time to fix it.

I agree that erlang.mk is too thorough when running some targets, but in my opinion not using it (or using an incompatible version of it) comes with the cost of unexpected behavior like this one.

Anyway, thanks again!

Cheers

sinasamavati commented 10 years ago

Thank you very much.

but in my opinion not using it (or using an incompatible version of it) comes with the cost of unexpected behavior like this one.

That's right. Maybe I'll think of adding it if an unexpected behaviour occurs again.