search

sinatra / mustermann

your personal string matching expert
http://sinatrarb.com/mustermann/
MIT License
664 stars 63 forks source link

v1.1.0 #100

Closed namusyaka closed 4 years ago

namusyaka commented 4 years ago

For 2.7.0, https://github.com/lsegal/yard/pull/1296 needs to be merged. For 2.6.5, I decided to use the workaround for the coverage decreasing issue.

namusyaka commented 4 years ago

..and, since we're having a breaking change on Mustermann::Mapper, I'll cut a new version which increases minor version.

dentarg commented 4 years ago

..and, since we're having a breaking change on Mustermann::Mapper, I'll cut a new version which increases minor version.

If there are breaking changes, shouldn't the major version be increased @namusyaka? README states that Mustermann is following https://semver.org/

namusyaka commented 4 years ago

@dentarg No. It's just a bug fix essentially. I don't think we should cut a new major version upgrade because of the potential incompatibility caused by the bug fix around "ruby". Even if we upgrade the major version, new ruby version introduces a new bug in the older versions such as 1.0.3.

I'm going to upgrade a major version when the public API is changed explicitly.

deepj commented 4 years ago

It's still not fixed yet. I get this warning with the lastest mustermann

~/.gem/ruby/2.7.0/gems/mustermann-1.1.0/lib/mustermann.rb:63: warning: The called method `new' is defined here
namusyaka commented 4 years ago

@deepj Looks like the warning is unrelated to the change/release. If you worried about it, please file a new issue with a reproducible code.