search

sinatra / mustermann

your personal string matching expert
http://sinatrarb.com/mustermann/
MIT License
664 stars 63 forks source link

Mustermann is not compatible with JRuby --enable=frozen-string-literal param #110

Closed brometeo closed 2 years ago

brometeo commented 4 years ago

It tries to modify a frozen String in the code line:

mustermann-1.1.1/lib/mustermann/ast/node.rb:59

brometeo commented 3 years ago

Any news about this issue? Opinion? :(

olleolleolle commented 3 years ago

@brometeo Would you like to offer a PR?

olleolleolle commented 3 years ago

https://github.com/sinatra/mustermann/blob/master/mustermann/lib/mustermann/ast/node.rb#L111 This line defines a String which is not mutable, and we need it to be. +"" would make a mutable String, whereas "" (the existing code) is a frozen one.

brometeo commented 3 years ago

@brometeo Would you like to offer a PR?

Pull Request? I need permission for updating code :)

namusyaka commented 3 years ago

I'll take a look at this after switching our Ci into actions. Sorry for the late reply.

michal-granec commented 2 years ago

If it's ok with you @namusyaka I can handle the PR for this issue. WDYT?

dentarg commented 2 years ago

Go for it

michal-granec commented 2 years ago

@olleolleolle and @namusyaka PR is ready to be reviewed. Let me know if there is anything I should change, add or try out :wink:

brometeo commented 2 years ago

Any news about this issue? It is very annoying :(

jkowens commented 2 years ago

I merged @michal-granec's PR into mustermann master, but we'll need @namusyaka to cut a release to get the fix out.

jkowens commented 2 years ago

Released 1.1.2