search

sinatra / mustermann

your personal string matching expert
http://sinatrarb.com/mustermann/
MIT License
664 stars 63 forks source link

CI: Add 3.0 and JRuby to the build matrix #112

Closed olleolleolle closed 3 years ago

olleolleolle commented 3 years ago

This PR only updates the CI matrix to the latest generally available Ruby versions.

Source for version numbers: https://github.com/rvm/rvm/blob/master/config/known

Did not include 3.0.0-preview2 Update: Added JRuby & 3.0, and allowed them to run with failures.

epergo commented 3 years ago

Did not include 3.0.0-preview2

I think we could add ruby 3 now that it has released a new minor, and maybe we could add Jruby too because sinatra itself supports it

olleolleolle commented 3 years ago

@epergo Thought: Do you think it'd be alright to only keep version specifiers like "2.7" in the list?

olleolleolle commented 3 years ago

Cool! "3.0" runs, and shows several ArgumentError! https://travis-ci.org/github/sinatra/mustermann/jobs/766897981

I added a new Issue, https://github.com/sinatra/mustermann/issues/114 to follow this.

olleolleolle commented 3 years ago

JRuby fails on attempting to use redcarpet, which has a C extension. /home/travis/build/sinatra/mustermann/vendor/bundle/jruby/2.5.0/gems/redcarpet-3.5.1/ext/redcarpet This has been explored in 2017, but still needs fixing; https://github.com/sinatra/mustermann/issues/72

epergo commented 3 years ago

@epergo Thought: Do you think it'd be alright to only keep version specifiers like "2.7" in the list?

Sounds good, Travis will download the latest minor version

As for Ruby 3 and jRuby errors, we can allow failures for them so we (aka someone with suppa powers 😄 ) can merge this now()

zzak commented 3 years ago

@olleolleolle Thanks for creating this!

I'm not sure about the jruby version, but I wonder if we can clean up and stop testing EoL'd versions of Ruby.

olleolleolle commented 3 years ago

@zzak I can drop every EOL'd version, right now.

The JRuby version is latest available. https://www.jruby.org/2021/03/29/jruby-9-2-17-0.html

olleolleolle commented 3 years ago

@zzak If you feel uneasy about adding a previously-not-there Ruby implementation, I can take that out of this PR, and move it to another Pull Request, which could be about "add JRuby to matrix AND make it pass green". How about that?

zzak commented 3 years ago

@olleolleolle I think it's fine but I just wasn't sure