Improve CI

[dentarg]

A couple of things.

[jkowens]

@dentarg thanks, can you rebase when you have a minute. That's awesome to see Actions has an allow-failure option. I didn't know it had been added!

[eregon]

Oops, I also made a PR adding fail-fast: false in https://github.com/sinatra/mustermann/pull/132

[eregon]

In any case, please only use continue-on-error for jruby because it's currently failing. The problem is step-level continue-on-error just marks the job as green even when something fails, which is quite confusing and is almost the same as not running that job.

That's awesome to see Actions has an allow-failure option.

Only a half-baked one I'm afraid: https://github.com/github-community/community/discussions/15452

[dentarg]

The problem is step-level continue-on-error just marks the job as green even when something fails

That's my preference, I want the green checkmarks when I look at the commit list. I think it is more important to show the green checkmark when everything we expect to work, works.

If you are curious if a "allowed to fail" job failed, you need to look that up. I've added the extra steps so that's a bit easier, but yes, that is still cumbersome as Actions doesn't provide a separate status for "failed but was allowed to fail" (as you explain in the community issue).

[jkowens]

In any case, please only use continue-on-error for jruby because it's currently failing. The problem is step-level continue-on-error just marks the job as green even when something fails, which is quite confusing and is almost the same as not running that job.

That's awesome to see Actions has an allow-failure option.

Only a half-baked one I'm afraid: github-community/community#15452

Ohh I see, bummer 😭

[dentarg]

Good to go?

[jkowens]

LGTM 👍