sinatra / mustermann

your personal string matching expert
http://sinatrarb.com/mustermann/
MIT License
663 stars 63 forks source link

truffleruby: not supported? flaky specs? bad specs? #143

Open dentarg opened 2 months ago

dentarg commented 2 months ago

I noticed this failure in CI, it ran on 2302dbc658d013762be7d8c3a3759d224956d4a7 but it passed on the next commit (and I haven't seen it before).

https://github.com/sinatra/mustermann/actions/runs/10680826128/job/29603153585#step:7:10 (link will eventually not show any logs)

Failures:

  1) Mustermann::Expander hash is expected not to be == 2122681340268910596
     Failure/Error: example { Mustermann::Expander.new('/foo')               .hash.should_not be == Mustermann::Expander.new('/bar').hash }
       `expect(2122681340268910596).not_to be == 2122681340268910596`
     # ./mustermann/spec/expander_spec.rb:105:in `block (3 levels) in <top (required)>'

Finished in 5.15 seconds (files took 4.76 seconds to load)
4011 examples, 1 failure

Failed examples:

rspec ./mustermann/spec/expander_spec.rb:105 # Mustermann::Expander hash is expected not to be == 2122681340268910596

rake aborted!
Command failed with status (1): [/home/runner/.rubies/truffleruby-24.0.2/bin/truffleruby -S rspec]
/home/runner/work/mustermann/mustermann/Rakefile:8:in `block in <top (required)>'
/home/runner/.rubies/truffleruby-24.0.2/bin/bundle:44:in `<main>'
Tasks: TOP => default => rspec
(See full trace by running task with --trace)
Error: Process completed with exit code 1.
dentarg commented 2 months ago

Seeing we have https://github.com/sinatra/mustermann/issues/72 and we allow JRuby to fail in CI, I will do the same for TruffleRuby. I'm not a TruffleRuby user myself, so I have no way of justifying spending time on this. Contributions from the community are appreciated.